Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont show empty string on spotlight #4214

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Conversation

preschian
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Nov 1, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 468df07
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/636129e3fad6ee0008de9479
😎 Deploy Preview https://deploy-preview-4214--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian marked this pull request as ready for review November 1, 2022 07:28
@preschian preschian requested a review from a team as a code owner November 1, 2022 07:28
@preschian preschian requested review from prachi00 and removed request for a team November 1, 2022 07:28
@codeclimate
Copy link

codeclimate bot commented Nov 1, 2022

Code Climate has analyzed commit 468df07 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao yangwao disabled auto-merge November 1, 2022 14:24
@yangwao yangwao disabled auto-merge November 1, 2022 14:24
@yangwao yangwao merged commit 42db7e0 into main Nov 1, 2022
@yangwao yangwao deleted the spotlight-not-empty-string branch November 1, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants