#4144 new wallet changes

[prachi00]

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

• Bugfix
• Feature
• Refactoring

What's new?

• PR closes wallet connect new design remarks #4144
• Requires deployment <rubick/magick_issue>
• <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality
• I've posted a screenshot of demonstrated change in this PR

Optional

• I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
• I've tested PR on mobile and everything seems works
• I found edge cases
• I've written some unit tests 🧪

Had issue bounty label?

• Fill up your KSM address:
  Payout

Community participation

• Are you at KodaDot Discord?

Screenshot

• My fix has changed something on UI; a screenshot is best to understand changes for others.
  

[netlify]

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	c99ff69
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/636c5b3cb32dd00008166218
😎 Deploy Preview	https://deploy-preview-4222--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[prachi00]

For now, I am showing all the wallets but showing the installed one at the top
Also, fixed all the UI/UX fixes mentioned by @exezbcz

[roiLeo]

Hey!
small notes from issue:

• can we increase size of wallet account item in the list (at least test it with min 48px height)
• could you try to fix disconnect btn wich is reloading the app/page or introduce change account btn?

Remain:

how can I know wich extension is supported on kodadot since we hide the one that are not installed?

we can try to display uninstalled wallet in another list like on solana

[prachi00]

small notes from issue:

@exezbcz for 1st, can we increase the height of these?

[prachi00]

@roiLeo so on disconnect we clear the session and reload the page, I am not sure if we should be removing this? I can take a look at `change account` btn though, but I need to need where to put it design wise @exezbcz

[roiLeo]

on disconnect we clear the session and reload the page, I am not sure if we should be removing this?

I don't know what this fixes maybe @preschian has an idea but from a user point of view I now find it compelling to change accounts on the platform

[preschian]

hi, the clear session on the disconnect button initially to anticipate these errors:

• Cache (weird) bug on Firefox #3842 (comment)
• Error when tryying to create identity on basilisk #4091 (comment)

previously, the only way for the user to clear the session is from a toast notification. the toast can be easily ignored when the user navigates to the other page. the toast itself will be triggered if there are new deployments. in case there is no new deployment and the users are stuck with an older cache, there is one alternative way to clear the cache, and I put that in the "Logout" button

does the clearSession() block this task?

[prachi00]

hi, the clear session on the disconnect button initially to anticipate these errors:

• Cache (weird) bug on Firefox #3842 (comment)
• Error when tryying to create identity on basilisk #4091 (comment)

previously, the only way for the user to clear the session is from a toast notification. the toast can be easily ignored when the user navigates to the other page. the toast itself will be triggered if there are new deployments. in case there is no new deployment and the users are stuck with an older cache, there is one alternative way to clear the cache, and I put that in the "Logout" button

does the clearSession() block this task?

maybe we can just add change account btn for now?

[preschian]

maybe we can just add change account btn for now?

yes, I think it would be better to add more section/button for switch/select an account
wdyt? @exezbcz @roiLeo

[roiLeo]

maybe we can just add change account btn for now?

Yep, I would love to see it again

[yangwao]

so on disconnect we clear the session and reload the page,

yes, let's keep this as there are some cache issue with some package which provides networks and I noticed it's not fully fixed as it was working previously

[prachi00]

created another issue for change button #4271

[roiLeo]

Waiting for #4144 final design

[prachi00]

@yangwao @exezbcz have we decided on the final design for this one yet?

[codeclimate]

Code Climate has analyzed commit c99ff69 and detected 0 issues on this pull request.

View more on Code Climate.

[exezbcz]

@yangwao @exezbcz have we decided on the final design for this one yet?

not yet, i will have a look on it after 15.11. I think we can leave it for now how it is.

[yangwao]

We should probably move the select box to be drop-down under connect menu

[yangwao]

we will redesign wallet menu once more time anyway

good for now

pay 50

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $50 @ 28.17 USD/KSM ~ 1.775 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x7532a654f665c2f8c3febc5f65107727d0a136abb74661aa4009e260a18dba0a

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues