Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4271 adding change account button #4272

Merged
merged 7 commits into from
Nov 10, 2022
Merged

#4271 adding change account button #4272

merged 7 commits into from
Nov 10, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Nov 6, 2022 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

PR Context?

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screen Shot 2022-11-05 at 5 58 56 PM

@prachi00 prachi00 requested a review from a team as a code owner November 6, 2022 00:59
@prachi00 prachi00 requested review from preschian and removed request for a team November 6, 2022 00:59
@kodabot
Copy link
Collaborator

kodabot commented Nov 6, 2022

SUCCESS @prachi00 PR for issue #4271 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Nov 6, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit dbf31fe
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/636c5b2a2f433f0009224be9
😎 Deploy Preview https://deploy-preview-4272--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao
Copy link
Member

yangwao commented Nov 6, 2022

@exezbcz I guess we can have much better design for this?

@prachi00
Copy link
Member Author

prachi00 commented Nov 7, 2022

Screen Shot 2022-11-06 at 8 39 41 PM
@yangwao @exezbcz updated the btns according to format, for the rest (asset, balance, usd), I feel like it should be a new issue since it would include logical changes and should be handled in a new issue

roiLeo
roiLeo suggested changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "Change Account" btn is not working on mobile for me

@roiLeo roiLeo added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Nov 7, 2022
@prachi00
Copy link
Member Author

prachi00 commented Nov 9, 2022

@roiLeo works now

@prachi00 prachi00 requested a review from roiLeo November 9, 2022 04:16
roiLeo
roiLeo reviewed Nov 9, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works now

Capture d’écran 2022-11-09 à 8 33 09 AM

☹️

@prachi00
Copy link
Member Author

prachi00 commented Nov 9, 2022 •
edited

works now

Capture d’écran 2022-11-09 à 8 33 09 AM

☹️

yeah so this will be fixed by #4222

roiLeo
roiLeo reviewed Nov 9, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small notes

components/rmrk/Profile/NavbarProfileDropdown.vue Outdated Show resolved Hide resolved
components/rmrk/Profile/NavbarProfileDropdown.vue Outdated Show resolved Hide resolved
styles/themes/_dark.scss Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Nov 10, 2022

Code Climate has analyzed commit dbf31fe and detected 0 issues on this pull request.

View more on Code Climate.

roiLeo
roiLeo approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm, let's finish #4222 too

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Nov 10, 2022
@yangwao
Copy link
Member

yangwao commented Nov 10, 2022

pay 50

@yangwao yangwao merged commit 029e3b4 into main Nov 10, 2022
@yangwao yangwao deleted the feat-add-change-account branch November 10, 2022 17:38
@yangwao
Copy link
Member

yangwao commented Nov 10, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 28.23 USD/KSM ~ 1.771 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x51f3429868cdb605018bfd06886e8dd5bff71ae5dcee27766d6739694c49bcae

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding change account button
4 participants
@prachi00 @kodabot @yangwao @roiLeo