Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 rmrk classic mint no price #4655

Merged
merged 5 commits into from
Jan 12, 2023
Merged

🔧 rmrk classic mint no price #4655

merged 5 commits into from
Jan 12, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jan 10, 2023

same stuff goes for bsx royalties

PR Type

  • Bugfix

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at YOLO

Screenshot 📸

Screenshot 2023-01-10 at 17-00-05 KodaDot - Kusama NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner January 10, 2023 16:04
@roiLeo roiLeo requested review from preschian and prachi00 and removed request for a team January 10, 2023 16:04
@netlify
Copy link

netlify bot commented Jan 10, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 8c6afb8
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c01b9c8d12500009e43919
😎 Deploy Preview https://deploy-preview-4655--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roiLeo roiLeo mentioned this pull request Jan 10, 2023
Merged
8 tasks
@yangwao yangwao requested a review from vikiival January 11, 2023 09:43
@vikiival
Copy link
Member

Tested: https://deploy-preview-4655--koda-nuxt.netlify.app/rmrk/gallery/16143102-8cc1b91e899d9be40e-2CENTS-BREAKFAST_IN_SUBWORK-0000000000000008

@vikiival
Copy link
Member

This branch has conflicts that must be resolved

components/rmrk/Create/CreateToken.vue

Let's resolve conflicts and can roll 🎲

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Jan 12, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 12, 2023

Code Climate has analyzed commit 8c6afb8 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

pay 40 usd

@vikiival vikiival merged commit 32a81c8 into kodadot:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

@prachi00 prachi00 Awaiting requested review from prachi00 prachi00 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLASSIC minting: Adding NFT to collection without listing it for sale (not working)
2 participants
@roiLeo @vikiival