Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 bsx classic mint no royalty #4656

Merged
merged 2 commits into from
Jan 11, 2023
Merged

🔧 bsx classic mint no royalty #4656

merged 2 commits into from
Jan 11, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jan 10, 2023 •
edited

continue from #4655

PR Type

  • Bugfix

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Screenshot 📸

Screenshot 2023-01-10 at 17-17-53 KodaDot Low fees and low carbon minting KodaDot - Kusama NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner January 10, 2023 16:20
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team January 10, 2023 16:20
@netlify
Copy link

netlify bot commented Jan 10, 2023 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 23412ef
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63be9c6339bc1f0008cf9a76
😎 Deploy Preview https://deploy-preview-4656--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Jarsen136
Jarsen136 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@yangwao yangwao requested a review from vikiival January 11, 2023 09:43
vikiival
vikiival reviewed Jan 11, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smol clarification otherwise LGTM

@vikiival
Copy link
Member

pay 50 usd

@codeclimate
Copy link

codeclimate bot commented Jan 11, 2023

Code Climate has analyzed commit 23412ef and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit 964e222 into kodadot:main Jan 11, 2023
@roiLeo roiLeo deleted the fix/bsx/create branch January 11, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Royalty toggle reversed behaviour
3 participants
@roiLeo @vikiival @Jarsen136