feat: network selector on explorer #4863

preschian · 2023-01-30T14:21:47Z

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Context

Closes Explorer Network switch #4886
branching from feat: sort options on explore #4846
related with Redesign Explorer v0.9 #4474

Before submitting pull request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality
I've posted a screenshot of demonstrated change in this PR

Optional

I've tested it at </bsx/collection>
I've tested PR on mobile
I've written unit tests 🧪
I've found edge cases

Had issue bounty label?

Fill up your KSM address: Payout

Community participation

Are you at KodaDot Discord?

Screenshot 📸

My fix has changed something on UI; a screenshot is best to understand changes for others.

…rer-chain-selector

netlify · 2023-01-30T14:21:52Z

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	`96a04e9`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/63da7282a7ef5b0008972fa4
😎 Deploy Preview	https://deploy-preview-4863--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

yangwao · 2023-01-30T15:09:20Z

powerful

exezbcz · 2023-01-30T16:15:01Z

Hiii, nice
one little change from the sort by issue

text to black - on k-accent(primary) we dont use white color because there is smaller contrast than with black.

can we please make the button work as in gallery chart; when you choose sub-option it became visible on the button.
so when I chose basilisk

the button should have the text - basilisk

Will we enable multi-select like on sort by? (not sure in this stage) If so, the number of activated options would be useful as well. cc @yangwao
Thanks!

preschian · 2023-01-31T03:14:59Z

text to black - on k-accent(primary) we dont use white color because there is smaller contrast than with black.

noted, will update the parent branch

can we please make the button work as in gallery chart; when you choose sub-option it became visible on the button.

in the current stage, the network is already selected
how about change the text to this for now: Network: Basilisk

Will we enable multi-select like on sort by? (not sure in this stage)

not in the current stage I guess. we can achieve it once we implemented fetching multi-chain

…rer-chain-selector

preschian · 2023-02-01T04:37:25Z

can we please make the button work as in gallery chart; when you choose sub-option it became visible on the button.

in the current stage, the network is already selected how about change the text to this for now: Network: Basilisk

need your feedback on this one cc @exezbcz @yangwao

roiLeo

in the current stage, the network is already selected how about change the text to this for now: Network: Basilisk

^ yes!

at the moment it's confusing to have written "All Networks" while only one is showing/selected

codeclimate · 2023-02-01T14:09:30Z

Code Climate has analyzed commit 96a04e9 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

View more on Code Climate.

exezbcz · 2023-02-01T14:18:27Z

can we make it to only display the network name without the "network:"

now the button is changing its width based on how long the name is - can we make it fixed?

otherwise alright! thanks

roiLeo · 2023-02-01T14:21:47Z

now the button is changing its width based on how long the name is - can we make it fixed?

are we sure about fixed width? it can have an impact on responsive mode

(note: we don't have Senk, Moonriver & Moonbeam on production so no long names)

Jarsen136 · 2023-02-01T14:29:39Z

components/explore/ExploreChain.vue

+    },
+    query: {
+      page: '1',
+      sort: route.query.sort,


how about adding the search keywords to query

will add this 👍

exezbcz · 2023-02-01T16:27:53Z

now the button is changing its width based on how long the name is - can we make it fixed?

are we sure about fixed width? it can have an impact on responsive mode

(note: we don't have Senk, Moonriver & Moonbeam on production so no long names)

hmm, what about something like minimal width? what are the other options how we can avoid button jumping? - there will be a layout change button in future - which would be influenced by this.
wdyt?

yangwao · 2023-02-01T17:30:34Z

Will we enable multi-select like on sort by?

probably not in this

how about change the text to this for now: Network: Basilisk

yes, could be

Terms of stuff in button, I would keep for sake clarity end user "Network" there as prefix, yet on dropdown could be w/o

rarible

yangwao · 2023-02-01T17:36:35Z

btw, sry disturbing lovely discussion, yet happy to move on and not get stuck on wording :D

yangwao · 2023-02-02T09:06:08Z

hmm could be fixed in other issue I guess?
Why it influences width of search bar?

Screen.Recording.2023-02-02.at.10.05.33.mov

yangwao · 2023-02-02T09:07:41Z

can we make it to only display the network name without the "network:"

we can still use some sort of label. People outside of Ethereum barely knows what are names of other parachains in Polkadot, not even canary networks on Kusama

yangwao · 2023-02-02T09:08:35Z

what are the other options how we can avoid button jumping? - there will be a layout change button in future - which would be influenced by this.

we can reflect in explorer feedback

yangwao · 2023-02-02T09:08:41Z

pay 50 usd

preschian added 2 commits January 30, 2023 21:20

feat: network selector on explorer

f619013

Merge branch 'main' of github.com:kodadot/nft-gallery into feat/explo…

03a3d71

…rer-chain-selector

Merge branch 'main' of github.com:kodadot/nft-gallery into feat/explo…

5f2d8e9

…rer-chain-selector

preschian marked this pull request as ready for review February 1, 2023 04:37

preschian requested a review from a team as a code owner February 1, 2023 04:37

preschian requested review from roiLeo and Jarsen136 and removed request for a team February 1, 2023 04:37

roiLeo reviewed Feb 1, 2023

View reviewed changes

This was referenced Feb 1, 2023

Upcoming March release #4884

Closed

Upcoming February Release #4838

Closed

Explorer Network switch #4886

Closed

preschian added 2 commits February 1, 2023 21:02

feat: change to Network: name

1da1bb8

chore: selected network

96a04e9

Jarsen136 reviewed Feb 1, 2023

View reviewed changes

yangwao mentioned this pull request Feb 2, 2023

GraphQL error: value "99999999000000000000" is out of range for type bigint #4894

Closed

yangwao merged commit 738f80b into main Feb 2, 2023

yangwao deleted the feat/explorer-chain-selector branch February 2, 2023 09:08

preschian mentioned this pull request Feb 2, 2023

feat: bring existing query to chain and sort #4902

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: network selector on explorer #4863

feat: network selector on explorer #4863

preschian commented Jan 30, 2023 •

edited by yangwao

Loading

netlify bot commented Jan 30, 2023 •

edited

Loading

yangwao commented Jan 30, 2023

exezbcz commented Jan 30, 2023 •

edited

Loading

preschian commented Jan 31, 2023

preschian commented Feb 1, 2023

roiLeo left a comment

codeclimate bot commented Feb 1, 2023

exezbcz commented Feb 1, 2023

roiLeo commented Feb 1, 2023 •

edited

Loading

Jarsen136 Feb 1, 2023

preschian Feb 2, 2023

exezbcz commented Feb 1, 2023

yangwao commented Feb 1, 2023

yangwao commented Feb 1, 2023

yangwao commented Feb 2, 2023

yangwao commented Feb 2, 2023

yangwao commented Feb 2, 2023

yangwao commented Feb 2, 2023

feat: network selector on explorer #4863

feat: network selector on explorer #4863

Conversation

preschian commented Jan 30, 2023 • edited by yangwao Loading

PR Type

Context

Before submitting pull request, please make sure:

Optional

Had issue bounty label?

Community participation

Screenshot 📸

netlify bot commented Jan 30, 2023 • edited Loading

✅ Deploy Preview for koda-nuxt ready!

yangwao commented Jan 30, 2023

exezbcz commented Jan 30, 2023 • edited Loading

preschian commented Jan 31, 2023

preschian commented Feb 1, 2023

roiLeo left a comment

Choose a reason for hiding this comment

codeclimate bot commented Feb 1, 2023

exezbcz commented Feb 1, 2023

roiLeo commented Feb 1, 2023 • edited Loading

Jarsen136 Feb 1, 2023

Choose a reason for hiding this comment

preschian Feb 2, 2023

Choose a reason for hiding this comment

exezbcz commented Feb 1, 2023

yangwao commented Feb 1, 2023

yangwao commented Feb 1, 2023

yangwao commented Feb 2, 2023

yangwao commented Feb 2, 2023

yangwao commented Feb 2, 2023

yangwao commented Feb 2, 2023

preschian commented Jan 30, 2023 •

edited by yangwao

Loading

netlify bot commented Jan 30, 2023 •

edited

Loading

exezbcz commented Jan 30, 2023 •

edited

Loading

roiLeo commented Feb 1, 2023 •

edited

Loading