-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefetch gallery Items on infinity scroll #4922
Conversation
WARNING @Jarsen136 PR for issue #4882 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4882 |
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I'm about to make a follow-up issue to add the prefetch strategy to all the other pages using infinity scroll. WDYT? |
seems going blazing fast! now I'm thinking mass-mints should be grouped somehow, I can't find issue but seen it few days ago hmm 😭 Screen.Recording.2023-02-05.at.17.44.47.mov |
oh, found issue, scrolling up is not so fast ? Screen.Recording.2023-02-05.at.17.50.57.mov |
Oh yes, Let me add prefetch also for srcoll up. Will fix it later. |
yes! I think it's doable. It's possible make it as util to dedupe code? |
Sure. Will make it reusable. |
Code Climate has analyzed commit eb7525a and detected 0 issues on this pull request. View more on Code Climate. |
It should be faster now when scrolling up. I have added prefetch for scrolling up, though it's not as smooth as scrolling down. I think it could be improved in the next issue. |
it's far so good for me! |
pay 50 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type
Context
prefetch pages on gallery items list
fetch the next pages ahead before hitting the bottom.
fix: infinity scroll can get glitched on gallery explore items page
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸