-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prefetch to all pages using infinite scroll #4946
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Might be time to migrate infiniteLoader to Vue composition api? |
Yes, but the infiniteLoader composition migration would be blocked by the vue3 refactoring of some big components, like We could implement the composition api for infinite scroll first. And then while refactoring some big list components, we could migrate the infiniteScroll composition one by one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is Debounce needed?
prefetching
could be replace by $fetchState.pending- empty return 😬
- (dom element won't work on SSR)
but ✅ wfm
Code Climate has analyzed commit 9948bb7 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
I still have to get to the finish before the content loads. Particularly on collections |
On the beta env, you have to scroll to the bottom to load next page in any case. While after adding prefetch, the next pages would be auto loaded if you scroll down in normal speed. |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸