Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 RMRK 2.0 beta #5028

Merged
merged 13 commits into from
Feb 20, 2023
Merged

🎉 RMRK 2.0 beta #5028

merged 13 commits into from
Feb 20, 2023

Conversation

vikiival
Copy link
Member

  • ⬆️ @kodadot1/vuex-options
  • ⚡ enable RMRK2
  • ⬆️ @kodadot1/vuex-options
  • 🔧 rmrk2 config
  • ⬆️ @kodadot1/vuex-options
  • 🎉 RMRK2

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • Closes #<issue_number>

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

@vikiival vikiival requested a review from a team as a code owner February 16, 2023 15:15
@vikiival vikiival requested review from roiLeo and Jarsen136 and removed request for a team February 16, 2023 15:15
@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 1436ca7
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63f28565e3dce60008f42231
😎 Deploy Preview https://deploy-preview-5028--koda-nuxt.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pages/rmrk2/index.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't work for me
Screenshot 2023-02-16 at 16-31-26 KodaDot - NFT Market Explorer

Some nftEntity name are null
collectionEntities name are null too

pages/rmrk2/index.vue Outdated Show resolved Hide resolved
Co-authored-by: roiLeo <medina.leo42@gmail.com>
@vikiival
Copy link
Member Author

Some nftEntity name are null

collectionEntities name are null too

Yes, infura had some outage while indexing.

See kodadot/workers#32

@yangwao
Copy link
Member

yangwao commented Feb 16, 2023

infura had some outage while indexing.

https://status.infura.io/ seems only for Polygon today?

can we switch to Pinata for indexer as we have there 100k req which should sufficient for indexing I guess?

image

@yangwao
Copy link
Member

yangwao commented Feb 16, 2023

fleek, cf-ipfs or someone from this list? https://ipfs.github.io/public-gateway-checker/

@yangwao
Copy link
Member

yangwao commented Feb 16, 2023

ok infura has really bad day

image

@yangwao
Copy link
Member

yangwao commented Feb 16, 2023

ok, for indexing we might have ipfs gateway, seems it's infura costs are $200 for what we've been paying at pinata $1k, but with r2 even lower, let's see, updating gateway to minipfs package

@preschian
Copy link
Member

preschian commented Feb 17, 2023

Some nftEntity name are null
collectionEntities name are null too

Yes, infura had some outage while indexing.

See kodadot/workers#32

hi @vikiival, are you sure this is infura side?
this nft name was returned null from subsquid https://deploy-preview-5028--koda-nuxt.netlify.app/rmrk2/gallery/12514775-32b258d8-DXD-ANGELS-00000044
but, the name already exists on the metadata from our image-workers

can you give us error log from subsquid side while indexing? so we can trace the error

@preschian
Copy link
Member

preschian commented Feb 17, 2023

ok, for indexing we might have ipfs gateway, seems it's infura costs are $200 for what we've been paying at pinata $1k, but with r2 even lower, let's see, updating gateway to minipfs package

this is infura usage from image-workers in the last 7 days (cache from cf-workers + r2 helps a lot to reduce the usage)
10GB * 30 days = 300GB = $35/monthly (roughly)
Screenshot 2023-02-17 at 10 58 46

@preschian
Copy link
Member

preschian commented Feb 17, 2023

Some nftEntity name are null
collectionEntities name are null too

Yes, infura had some outage while indexing.

See kodadot/workers#32

oohh, just want to make sure. did you hit infura endpoint directly while indexing, or hit our image-workers? I think it better to hit our image-workers (not sure if our workers can handle that or not)

@yangwao
Copy link
Member

yangwao commented Feb 17, 2023

@yangwao
Copy link
Member

yangwao commented Feb 17, 2023

I think we will have issues with numbers, not sure if they are right?
https://deploy-preview-5028--koda-nuxt.netlify.app/rmrk2/collection/90c6619c6b94fcfd34-EVRLOOT_RESOURCES?page=1

image

@yangwao
Copy link
Member

yangwao commented Feb 17, 2023

Different currencies on cards

image

@yangwao
Copy link
Member

yangwao commented Feb 17, 2023

seems stil syncing

"name": "009-rc0",
"squidName": "rubick",
"status": "SYNCING",
"syncStatus": {
"totalBlocks": 16673334,
"currentBlock": 15517829

@yangwao
Copy link
Member

yangwao commented Feb 17, 2023

Ok, my proposal would be to merge it partially it's working and there needs to be done lot of fixes beyond this PR

@preschian
Copy link
Member

Ok, my proposal would be to merge it partially it's working and there needs to be done lot of fixes beyond this PR

yes yes, at least finally we can landing RMRK 2.0

separate discussion for null on name and collection

@vikiival
Copy link
Member Author

or hit our image-workers? I think it better to hit our image-workers

using minipfs

https://github.com/kodadot/rubick/blob/zlozenec/src/mappings/utils/metadata.ts

@yangwao
Copy link
Member

yangwao commented Feb 19, 2023

Let's push it on beta :)

@codeclimate
Copy link

codeclimate bot commented Feb 19, 2023

Code Climate has analyzed commit 1436ca7 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Feb 20, 2023

now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants