Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sub path ipfs #32

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

preschian
Copy link
Member

@preschian preschian marked this pull request as ready for review February 3, 2023 14:55
@preschian
Copy link
Member Author

maybe deploy from this branch to test it out?
cc @yangwao @vikiival

@vikiival
Copy link
Member

vikiival commented Feb 3, 2023

@preschian

Total Upload: 42.26 KiB / gzip: 10.26 KiB
Uploaded image-beta (2.93 sec)
Published image-beta (1.57 sec)
  https://image-beta.kodadot.workers.dev
Current Deployment ID: 60d99d20-f6c0-4ff1-a352-a0e0af5d80f3

@preschian
Copy link
Member Author

seems fine, merge this and continue on image production?
kodadot/nft-gallery#4872 (comment)
cc @yangwao @vikiival

@vikiival
Copy link
Member

Actually, metadata loading takes a while these days

@preschian
Copy link
Member Author

Actually, metadata loading takes a while these days

is there any links for that specific metadata? will check it

@vikiival
Copy link
Member

Anything from valentine coletion /bsx/collection/14022023

@preschian
Copy link
Member Author

preschian commented Feb 13, 2023

Anything from valentine coletion /bsx/collection/14022023

I just got some ideas from this issue kodadot/nft-gallery#4984 (comment). should we try to fetch metadata from nftstorage also for image-worker? like this commit? kodadot/snek@a6f69d5

maybe infura had some big latency for getting new ipfs content?

currently, the images-worker fetch from infura only https://github.com/kodadot/workers/blob/main/image-beta/src/index.ts#L33-L36

@vikiival
Copy link
Member

Yeah but nft-storage fails when you pass to many requests

@yangwao
Copy link
Member

yangwao commented Feb 14, 2023

Can we use https://nftstorage.link/ ?

@vikiival
Copy link
Member

No, because it throws 429 after 10 requests

@preschian
Copy link
Member Author

Actually, metadata loading takes a while these days

oohh, I think I know what the root cause is. there is some partial outage on infura ipfs on 10 jan
image
source: https://status.infura.io/

I think we need to find another dedicated gateway. just in case infura down
currently we are only using infura https://github.com/kodadot/workers/blob/main/image-beta/wrangler.toml#L8-L9

@vikiival
Copy link
Member

So let's merge this?

@vikiival vikiival merged commit de1ba5e into kodadot:main Feb 16, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants