Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge me when this day ends #5615

Merged
merged 223 commits into from
Apr 12, 2023
Merged

Merge me when this day ends #5615

merged 223 commits into from
Apr 12, 2023

Conversation

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 12, 2023

AI-Generated Summary: This pull request includes multiple changes across various files, addressing updates to dependencies, prefix modifications, new features, and code refactoring. Key changes are:

  1. Upgrading dependencies for better compatibility and improved features.
  2. Replacing 'rmrk2' with 'ksm' in various places and updating related logic.
  3. Improvements to URL prefix handling and Fallout navigation.
  4. Deleting redundant components and refactoring others.
  5. Introducing new components such as FilterFloatButton, NeoModal, NotificationItem, and NotificationBoxButton as well as related code and styling.
  6. Numerous updates to Vuex storage, GraphQL queries, and styling.
  7. Modifications to conditional checks, functions, and constants in several files.
  8. Localization updates and adjustments in the codebase.

Please verify all changes and test the application after merging to ensure everything works as expected.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Apr 12, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 12, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 12, 2023

AI-Generated Summary: This pull request includes updates and changes to various files related to dependency updates, changing the chain prefix from 'rmrk2' to 'ksm', updating the user interface, adding new functionalities, and code optimization.

Some key updates include:

  • Modifications to package.json for dependency updates and a new component NeoModal.
  • Updates to existing components, such as NavbarExploreOptions.vue, GalleryItemActivityTable.vue, ConnectWalletModal.vue, and TheFooter.vue.
  • The introduction of new components, such as NotificationBoxModal.vue, NotificationItem.vue, and NotificationBoxButton.vue.
  • GraphQL query updates in files like collectionByAccount.graphql, notificationsByAccount.graphql, and nftById.graphql.
  • Changes to files like GalleryItemOffers.vue, Flipper.vue, transactionList.ts, and OwnerInsights.vue, implementing various improvements and optimizations.
  • Updates to styles and variables in styles/global.scss, styles/abstracts/_variables.scss, and other component SCSS files.

Overall, this pull request aims to improve the application's functionalities, optimize code, enhance user experience, and account for the change in chain prefix.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 12, 2023

AI-Generated Summary: This pull request primarily focuses on updating the naming conventions and conditions from using 'rmrk2' to 'ksm' throughout numerous files. Several components have been updated with more modular and reusable code by utilizing composables, and dependency updates have also been made for improved project stability.

Significant changes have been made to some components, including HolderTab.vue, GalleryItemPreviewer.vue, and Flipper.vue, to optimize their performance and user experience by implementing lazy loading and intersection observers to load more items as the user scrolls through the list.

New components have been added, such as NotificationBoxButton.vue, NotificationBoxModal.vue, and NotificationItem.vue, for handling notifications within the application. Additionally, a floating filter button called FilterFloatButton.vue has been added for better mobile experience in filtering.

The metadata properties have been updated to provide more flexibility in choosing the image URL based on the available metadata. Overall enhancements were made to filtering and event systems, as well as changes to Git queries and GraphQL queries. New types, constants, functions, and a Vue component called NeoModal have also been introduced.

Finally, minor changes, such as styling adjustments and conditional rendering updates, have been made to improve the overall appearance and logic of the application.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 12, 2023

AI-Generated Summary: This pull request includes various changes, some of which are:

  • Replacing instances of 'rmrk2' with 'ksm' in the codebase.
  • Adding new components like NotificationBoxButton, NotificationItem, and NotificationBoxModal.
  • Updating style rules by adding !important, removing empty lines, and introducing new CSS classes.
  • Enhancing support for domain name parsing and handling with rmrk2 chain prefixes.
  • Updating conditions for rendering components and handling events based on the updated urlPrefix values.
  • Introducing new utility functions and composables such as useActiveRouterFilters and useNotification.
  • Deleting unused files like CreativeMint.vue and pages/rmrk/creative.vue.
  • Simplifying code in certain areas, such as extracting logic into separate composables or hooks.

These changes, when combined, result in an improved codebase with a focus on readability, maintainability, and consistency throughout.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 12, 2023

AI-Generated Summary: This pull request includes a variety of updates related to code refactoring, new feature implementation, dependency upgrades, and file renaming. Key changes include:

  • Renaming of several files and updating corresponding import statements and conditions, mainly replacing 'rmrk2' with 'ksm'.
  • Removal of unused functions and types, such as 'rmrk2ToKsm' and 'BackwardPrefix'.
  • Addition of new Vue components, such as NotificationItem.vue, FilterFloatButton.vue, and NeoModal.vue.
  • New features like lazy-loading, mobile filters, and notifications have been added and optimized for user experience.
  • Several updates to Vuex state management, incorporating new properties, and updating related getter and action functions.
  • Dependency upgrades have been made to various packages, such as eslint, sass, and vitest, ensuring their latest stable versions are used.
  • Changes to localization support in the en.json locale file have been made to accommodate new features and enhancements added to the application.
  • Numerous code refactoring, simplification, and optimization updates have been applied throughout the diff.

Overall, this pull request improves the project's organization, maintainability, and functionality, while also setting the stage for future improvements and enhancements.

fix: no margin bottom on collection items
@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 12, 2023

AI-Generated Summary: This pull request makes numerous updates throughout the application involving components, utilities, types, and GraphQL queries. Major changes include:

  • Replacing instances of 'rmrk2' with 'ksm' in conditions, imports, typings, and key values.
  • Updating pagination and URL generation through destructuring and modification of query parameters.
  • Enhancing components such as Flipper, CreativeMint, ExploreTabs, and others with refined functionality and styling.
  • Improving the handling and calculation of balance values based on the URL prefix.
  • Adding new components like NotificationBoxButton, NeoModal, and FilterFloatButton.
  • Introducing new GraphQL queries for collectionByAccount and notificationsByAccount.
  • Updating dependencies and removing unnecessary ones for better project maintenance.
  • Deleting unnecessary components, files, and code blocks for a cleaner codebase.

These changes provide a better user experience, improved functionality, and enhanced maintainability of the application.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 12, 2023

AI-Generated Summary: This pull request introduces several modifications across numerous files, including updates to the handling of chain prefixes, the addition of new components, and adjustments to queries and file locations. Key changes involve replacing instances of 'rmrk2' with 'ksm', adding the FilterFloatButton and NeoModal components, and introducing performance optimizations for scrolling functions in various components. Additionally, there are updates to dependencies, a switch from sessionStorage to localStorage, modifications to conditions within functions, and numerous code refactorings to improve maintainability and readability.

@yangwao
Copy link
Member Author

yangwao commented Apr 12, 2023

when it builds I'm with release it tho 👀

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 12, 2023

AI-Generated Summary: This pull request includes a wide range of updates and changes, such as:

  1. Modifications to GraphQL queries and file paths, updating 'rmrk2' to 'ksm' and adding new queries (e.g., notificationsByAccount.graphql).
  2. UI adjustments for components like NeoTooltip.vue, ScrollTopButton.vue, HolderTab.vue, and NotificationBoxModal.vue.
  3. Improvements to performance and functionality with the introduction of features like the intersection observer and dynamic loading of content based on viewport scrolling.
  4. Consolidation of type definitions and simplification of code (e.g., replacing BackwardPrefix with Prefix and removing unnecessary functions and checks).
  5. Updates to package dependencies and build workflow configuration.

Overall, these changes contribute to an improved and more efficient application, addressing various aspects of code quality, functionality, and user experience.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 12, 2023

AI-Generated Summary: This pull request introduces various updates and improvements to the application, such as:

  • Changes in conditions to check for 'ksm' instead of 'rmrk2' in several components.
  • Updates to the Holder component and Flipper component views to implement lazy loading and enhance display.
  • A new NeoModal component based on Oruga's OModal for the updated design pattern.
  • Updates in URL prefix handling and path changes for specific cases.
  • Removal of the CreativeMint page and the associated option from the CreateDropdown and Navbar.
  • Introduction of a new custom Vue composition API for handling notifications.
  • Renaming and moving GraphQL files for 'ksm' instead of 'rmrk2'.
  • Dependency updates for better performance and compatibility.
  • Overall enhancements in code readability, user experience, and responsiveness.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants