Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rmrk2.kodadot.xyz redirect url #5758

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Apr 21, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at fb5d2a0

This pull request improves the handling of chain prefixes in the NFT gallery app. It uses the usePrefix composable to unify and simplify the prefix logic, and fixes some issues in the prefix.ts middleware.

🤖 Generated by Copilot at fb5d2a0

We are the masters of the chain
We use the prefix to control the domain
We fix the bugs and refactor the code
We use the composable to lighten the load

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 21, 2023 15:38
@Jarsen136 Jarsen136 requested review from vikiival and daiagi and removed request for a team April 21, 2023 15:38
@kodabot
Copy link
Collaborator

kodabot commented Apr 21, 2023

SUCCESS @Jarsen136 PR for issue #5746 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Apr 21, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit fb5d2a0
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6442ade8ee27260008208d3a
😎 Deploy Preview https://deploy-preview-5758--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Apr 21, 2023

Code Climate has analyzed commit fb5d2a0 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 21, 2023

AI-Generated Summary: This pull request modifies the handling of URL redirects and prefixes for rmrk2 domains. It makes two primary changes in composables/usePrefix.ts and middleware/prefix.ts.

In composables/usePrefix.ts, a new function setUrlPrefix is added to update the storage value of the selected prefix.

In middleware/prefix.ts, the logic for handling chain prefixes in the path is updated to ensure proper redirects and updates to the URL prefix in various scenarios involving rmrk2 domains.

The result is better support and accuracy for handling chains, prefixes, and domain-specific routing on the rmrk2 platform.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 21, 2023
@yangwao
Copy link
Member

yangwao commented Apr 21, 2023

pay 30 usd
probably it works!

@yangwao
Copy link
Member

yangwao commented Apr 21, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 31.08 USD/KSM ~ 0.965 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x683c08bba1c653391333e08f59f7162a1ff9deb33f14a5e899f6563eeeefc0b5

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 21, 2023
@yangwao yangwao merged commit fe3edd0 into kodadot:main Apr 21, 2023
15 of 17 checks passed
This was referenced Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rmrk2.kodadot.xyz
3 participants