Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit display on snek network #5821

Merged
merged 4 commits into from
May 1, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Apr 27, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

image

Copilot Summary

🤖 Generated by Copilot at 4408de1

Removed hardcoded value from getKusamaAssetId function in utils/api/bsx/query.ts. This allows the function to return the correct asset id for the Kusama network based on the input network name.

🤖 Generated by Copilot at 4408de1

No more return 5
getKusamaAssetId works
With networks object

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 27, 2023 15:40
@Jarsen136 Jarsen136 requested review from roiLeo and vikiival and removed request for a team April 27, 2023 15:40
@kodabot
Copy link
Collaborator

kodabot commented Apr 27, 2023

SUCCESS @Jarsen136 PR for issue #5819 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Apr 27, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d7706a7
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/644d498563bf6c0008a315a2
😎 Deploy Preview https://deploy-preview-5821--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 27, 2023

AI-Generated Summary: This pull request contains a change in the utils/api/bsx/query.ts file, fixing the unit display on the snek network by removing a superfluous return statement. The code now returns the correct 'bsx' and 'rmrk' cases, skipping the unnecessary 'snek' case.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 27, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about that one:

    // '0' if paying in bsx (on Basilisk and Snek)
    // '1' if paying in ksm (on basilisk)
    // '5' if paying in ksm (on Snek)

@roiLeo roiLeo mentioned this pull request Apr 28, 2023
8 tasks
@Jarsen136
Copy link
Contributor Author

Not sure about that one:

    // '0' if paying in bsx (on Basilisk and Snek)
    // '1' if paying in ksm (on basilisk)
    // '5' if paying in ksm (on Snek)

Could you pls review this? @vikiival 👀

@vikiival
Copy link
Member

Yes this is still correct

Screenshot 2023-04-28 at 17 18 49

Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would point to Phala token on snek

@Jarsen136
Copy link
Contributor Author

Query assetList does not return the asset id of 5, that's why we have the unit display. So I think it's a resolver issue related to snek squid side.

image

@vikiival
Copy link
Member

SNEK (rococo)

https://squid.subsquid.io/snekk/v/004/graphql

Screenshot 2023-04-29 at 13 54 57

BSX

https://squid.subsquid.io/snekk/v/005/graphql

Screenshot 2023-04-29 at 13 55 45

@codeclimate
Copy link

codeclimate bot commented Apr 29, 2023

Code Climate has analyzed commit d7706a7 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

SNEK (rococo)

https://squid.subsquid.io/snekk/v/004/graphql

BSX

https://squid.subsquid.io/snekk/v/005/graphql

Thanks for checking the query. Then I got the root reason why it does not work. Please review the code again.

@Jarsen136 Jarsen136 requested a review from vikiival April 29, 2023 16:50
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wfm, I think I'll remove this plugin in #5655

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 1, 2023
@vikiival vikiival merged commit d60dab2 into kodadot:main May 1, 2023
18 of 19 checks passed
@roiLeo
Copy link
Contributor

roiLeo commented May 2, 2023

Hello, something might be wrong with this change (tested on /snek/create)
Screenshot 2023-05-02 at 09-03-53 KodaDot Low fees and low carbon minting KodaDot - NFT Market Explorer

@vikiival
Copy link
Member

vikiival commented May 2, 2023

This would point to Phala token on snek

cc @roiLeo

@vikiival
Copy link
Member

vikiival commented May 2, 2023

Hello, something might be wrong with this change

My bet is that someone changed the token number for snek (propably check assetList)

@roiLeo
Copy link
Contributor

roiLeo commented May 2, 2023

My bet is that someone changed the token number for snek (propably check assetList)

I think I made a change recently on Money component that might be related

edit: issue with this.$route.params.prefix from PrefixMixin

@roiLeo roiLeo mentioned this pull request May 2, 2023
@yangwao yangwao mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix the unit display on snek item
4 participants