Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 ChainMoney composition api #5823

Merged
merged 4 commits into from
May 10, 2023
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Apr 28, 2023

PR Type

  • Bugfix
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Screenshot 📸

Capture d’écran 2023-04-28 à 11 32 17 AM

with Unit fix
Capture d’écran 2023-04-28 à 11 41 42 AM

Copilot Summary

🤖 Generated by Copilot at f10572b

Refactored ChainMoney component to use Vue 3 and support multiple chains. Replaced unit prop with chainSymbol and used useChain hook.

🤖 Generated by Copilot at f10572b

Sing, O Muse, of the skillful coder who updated
The ChainMoney component, a shining display of value,
To use the new features of Vue 3, the framework divine,
And to support different networks, the realms of many chains.

@netlify
Copy link

netlify bot commented Apr 28, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 65262d4
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/645b8a1340403600088f384c
😎 Deploy Preview https://deploy-preview-5823--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Apr 28, 2023

AI-Generated Summary: This pull request updates the ChainMoney.vue component to use the Composition API, simplifies the module format, and removes the usage of mixins. It also refactors the component to use the chainSymbol and decimals properties from useChain() instead of passing them as props.

@reviewpad reviewpad bot added the small Pull request is small label Apr 28, 2023
@roiLeo roiLeo marked this pull request as ready for review May 1, 2023 09:24
@roiLeo roiLeo requested a review from a team as a code owner May 1, 2023 09:24
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team May 1, 2023 09:24
@roiLeo roiLeo requested review from a team, vikiival and daiagi and removed request for preschian, Jarsen136 and a team May 1, 2023 09:27
@daiagi
Copy link
Contributor

daiagi commented May 1, 2023

image

should these be KSM?

@roiLeo roiLeo marked this pull request as draft May 2, 2023 07:04
@vikiival
Copy link
Member

vikiival commented May 2, 2023

Yup

@roiLeo
Copy link
Contributor Author

roiLeo commented May 10, 2023

should these be KSM?

it's not related with this PR, as I can reproduce this on https://canary.kodadot.xyz/transfer/

@roiLeo roiLeo marked this pull request as ready for review May 10, 2023 12:12
@codeclimate
Copy link

codeclimate bot commented May 10, 2023

Code Climate has analyzed commit 65262d4 and detected 0 issues on this pull request.

View more on Code Climate.

value: number | string | undefined
inline?: boolean
hideUnit?: boolean
}>(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks oki

@vikiival vikiival merged commit a8c8f8d into kodadot:main May 10, 2023
18 of 19 checks passed
@vikiival
Copy link
Member

pay 30 usd

@yangwao yangwao mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong currency on bsx
3 participants