feat: set multi chain balances in stores #6052

preschian · 2023-05-20T09:24:37Z

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Context

Closes fetch multi chain Balance from pinia store #6059
Closes Balance bug on rmrk2 #5838
Closes Zero balance on kusama/rmrk2 #5986
Closes Multi-chain assets in wallet dialog #4865
Closes Checking your balance is confusing for people who are not familiar with KodaDot #5850

Had issue bounty label?

Fill up your KSM address: Payout

Copilot Summary

`🤖 Generated by Copilot at c4402e4`

Refactored the balance component and the identity store to handle multiple balances for different chains and tokens. Used a new ref and a getter to access and display the balance data in a consistent and reactive way. Improved the component performance by removing unnecessary computations.

`🤖 Generated by Copilot at c4402e4`

Sing, O Muse, of the skillful refactorer
Who improved the component of balances
By using the store of identity
And its new ref of multiBalances

…-chain-balances

…llery into feat/multi-chain-balances-to-stores

…-chain-balances-to-stores

netlify · 2023-05-22T07:39:38Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`2a17f0a`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/646deb90cf9c03000868e992
😎 Deploy Preview	https://deploy-preview-6052--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

daiagi

works nicely

just small stuff

stores/identity.ts

Co-authored-by: Luke Fishman <daiagi@gmail.com>

roiLeo

I noticed a small issue, it doesn't show BSX for my wallet: (low balance)

on beta

on preview

Co-authored-by: roiLeo <medina.leo42@gmail.com>

codeclimate · 2023-05-22T09:38:01Z

Code Climate has analyzed commit 7a85462 and detected 0 issues on this pull request.

View more on Code Climate.

preschian · 2023-05-22T09:45:26Z

I noticed a small issue, it doesn't show BSX for my wallet: (low balance)

is this your address? seems like on subcan and sub.id also show zero

let me check if a change to maximumFractionDigits: 4,

roiLeo · 2023-05-22T09:48:09Z

I noticed a small issue, it doesn't show BSX for my wallet: (low balance)

is this your address? seems like on subcan and sub.id also show zero
* https://basilisk.subscan.io/account/bXhWeVLtArWauM8UmbaVdDmXmo5uSDk6DAa2YxQ5zbt2sDcbW

* https://sub.id/bXhWeVLtArWauM8UmbaVdDmXmo5uSDk6DAa2YxQ5zbt2sDcbW/balances

Yes it's mine! as you can see some KSM has been transfered

let me check if a change to maximumFractionDigits: 4,

If it only happens in my case I don't know if it is necessary to change it

preschian · 2023-05-22T10:08:39Z

If it only happens in my case I don't know if it is necessary to change it

let's keep it for now? in case the designers or our users prefer more digits we can just change maximumFractionDigits to the number we want

this is the result with

{
  minimumFractionDigits: 0,
  maximumFractionDigits: 4,
}

roiLeo

✅ wfm

prury · 2023-05-23T17:08:46Z

Working fine!

yangwao · 2023-05-24T10:18:15Z

@preschian let's resolve conflicts and it's up for merge! :)

yangwao · 2023-05-24T10:19:13Z

pay 100 usd extra for smashing 5 issues in one PR! 🤩

yangwao · 2023-05-24T10:19:27Z

😍 Perfect, I’ve sent the payout
💵 $100 @ 25.05 USD/KSM ~ 3.992 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x6b3fdd9c7a381e1d23aaca71ae77fd5a3766bccf8d1f53220432a417d7b5dd81

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

…-chain-balances-to-stores

vikiival · 2023-05-24T11:22:57Z

components/balance/MultipleBalances.vue

@@ -95,15 +85,20 @@ function calculateUsd(amount: string, token = 'KSM') {

  return calculateExactUsdFromToken(
    amountToNumber,
-    Number(fiatStore.getCurrentTokenValue(token))
+    Number(


Number(fiatStore.getCurrentTokenValue(token))

vikiival · 2023-05-24T11:23:09Z

components/balance/MultipleBalances.vue

-  Polkadot: 'dot',
+  kusama: 'ksm',
+  basilisk: 'bsx',
+  statemine: 'stmn',


missing polkadot

vikiival · 2023-05-24T11:23:25Z

stores/identity.ts

@@ -27,6 +28,26 @@ type ChangeAddressRequest = {
  apiUrl?: string
 }

+type ChainType = 'kusama' | 'basilisk' | 'statemine'


vikiival · 2023-05-24T11:23:33Z

stores/identity.ts

+  selected: boolean
+  address: string
+}
+type ChainToken = Partial<Record<'ksm' | 'bsx', ChainDetail>>


vikiival · 2023-05-24T11:23:47Z

stores/identity.ts

+    multiBalances: DEFAULT_MULTI_BALANCE_STATE,
+    multiBalanceAssets: [
+      { chain: 'kusama' },
+      { chain: 'statemine' },


{ chain: 'polkadot' },

vikiival

cc @preschian

preschian added 2 commits May 19, 2023 15:22

Merge branch 'main' of github.com:kodadot/nft-gallery into feat/multi…

22304d9

…-chain-balances

feat: set multi chain balances in stores

fbc935d

reviewpad bot added the large Pull request is large label May 20, 2023

preschian changed the title ~~Feat/multi-chain-balances-to-stores~~ feat: set multi chain balances in stores May 20, 2023

Merge branch 'feat/multi-chain-balances' of github.com:kodadot/nft-ga…

c4402e4

…llery into feat/multi-chain-balances-to-stores

reviewpad bot added medium Pull request is medium and removed large Pull request is large labels May 20, 2023

yangwao mentioned this pull request May 20, 2023

feat: multi chain balances #6019

Merged

10 tasks

Base automatically changed from feat/multi-chain-balances to main May 20, 2023 13:43

yangwao mentioned this pull request May 21, 2023

fetch multi chain Balance from pinia store #6059

Closed

preschian added 2 commits May 22, 2023 14:34

Merge branch 'main' of github.com:kodadot/nft-gallery into feat/multi…

59055e6

…-chain-balances-to-stores

refactor: add resetMultipleBalances()

5a0daab

refactor: fic deepscan and deepsource

31712e6

preschian marked this pull request as ready for review May 22, 2023 08:25

preschian requested a review from a team as a code owner May 22, 2023 08:25

preschian requested review from daiagi and Jarsen136 and removed request for a team May 22, 2023 08:25

reviewpad bot added the waiting-for-review label May 22, 2023

daiagi suggested changes May 22, 2023

View reviewed changes

stores/identity.ts Outdated Show resolved Hide resolved

stores/identity.ts Show resolved Hide resolved

roiLeo reviewed May 22, 2023

View reviewed changes

stores/identity.ts Outdated Show resolved Hide resolved

refactor: avoid magic numbers

37b837d

Co-authored-by: Luke Fishman <daiagi@gmail.com>

roiLeo reviewed May 22, 2023

View reviewed changes

refactor: Vue.set replacement

7a85462

Co-authored-by: roiLeo <medina.leo42@gmail.com>

preschian requested a review from daiagi May 22, 2023 10:08

roiLeo approved these changes May 22, 2023

View reviewed changes

roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 22, 2023

daiagi approved these changes May 22, 2023

View reviewed changes

daiagi added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels May 22, 2023

Jarsen136 approved these changes May 23, 2023

View reviewed changes

yangwao enabled auto-merge May 24, 2023 10:19

yangwao added the paid pull-request has been paid label May 24, 2023

Merge branch 'main' of github.com:kodadot/nft-gallery into feat/multi…

2a17f0a

…-chain-balances-to-stores

yangwao merged commit 5bf0696 into main May 24, 2023

yangwao deleted the feat/multi-chain-balances-to-stores branch May 24, 2023 10:48

vikiival reviewed May 24, 2023

View reviewed changes

components/balance/MultipleBalances.vue

Polkadot: 'dot',

kusama: 'ksm',

basilisk: 'bsx',

statemine: 'stmn',

Copy link

Member

vikiival May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing polkadot

vikiival reviewed May 24, 2023

View reviewed changes

stores/identity.ts

selected: boolean

address: string

}

type ChainToken = Partial<Record<'ksm' | 'bsx', ChainDetail>>

Copy link

Member

vikiival May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'dot'

vikiival reviewed May 24, 2023

View reviewed changes

yangwao mentioned this pull request May 24, 2023

add showing DOT balances to sidebar #6091

Closed

preschian mentioned this pull request May 24, 2023

fix: re-add dot in sidebar #6098

Merged

4 tasks

This was referenced May 25, 2023

beta update #6105

Merged

release update #6106

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: set multi chain balances in stores #6052

feat: set multi chain balances in stores #6052

preschian commented May 20, 2023 •

edited

Loading

netlify bot commented May 22, 2023 •

edited

Loading

daiagi left a comment

roiLeo left a comment

codeclimate bot commented May 22, 2023

preschian commented May 22, 2023

roiLeo commented May 22, 2023

preschian commented May 22, 2023 •

edited

Loading

roiLeo left a comment

prury commented May 23, 2023

yangwao commented May 24, 2023

yangwao commented May 24, 2023

yangwao commented May 24, 2023

vikiival May 24, 2023

vikiival May 24, 2023

vikiival May 24, 2023

vikiival May 24, 2023

vikiival May 24, 2023

vikiival left a comment

feat: set multi chain balances in stores #6052

feat: set multi chain balances in stores #6052

Conversation

preschian commented May 20, 2023 • edited Loading

PR Type

Context

Had issue bounty label?

Copilot Summary

🤖 Generated by Copilot at c4402e4

🤖 Generated by Copilot at c4402e4

netlify bot commented May 22, 2023 • edited Loading

✅ Deploy Preview for koda-canary ready!

daiagi left a comment

Choose a reason for hiding this comment

roiLeo left a comment

Choose a reason for hiding this comment

codeclimate bot commented May 22, 2023

preschian commented May 22, 2023

roiLeo commented May 22, 2023

preschian commented May 22, 2023 • edited Loading

roiLeo left a comment

Choose a reason for hiding this comment

prury commented May 23, 2023

yangwao commented May 24, 2023

yangwao commented May 24, 2023

yangwao commented May 24, 2023

vikiival May 24, 2023

Choose a reason for hiding this comment

vikiival May 24, 2023

Choose a reason for hiding this comment

vikiival May 24, 2023

Choose a reason for hiding this comment

vikiival May 24, 2023

Choose a reason for hiding this comment

vikiival May 24, 2023

Choose a reason for hiding this comment

vikiival left a comment

Choose a reason for hiding this comment

preschian commented May 20, 2023 •

edited

Loading

`🤖 Generated by Copilot at c4402e4`

`🤖 Generated by Copilot at c4402e4`

netlify bot commented May 22, 2023 •

edited

Loading

preschian commented May 22, 2023 •

edited

Loading