Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 burn only on active offers #6058

Merged
merged 2 commits into from
May 22, 2023
Merged

🔥 burn only on active offers #6058

merged 2 commits into from
May 22, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented May 21, 2023

PR Type

  • Bugfix

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Copilot Summary

🤖 Generated by Copilot at 719537c

The pull request enhances the NFT burning feature by adding a new query to fetch valid offers and using a safer batch method to execute the transactions. It affects the files transactionBurn.ts and acceptableOfferListByNftId.graphql.

🤖 Generated by Copilot at c79fcea

No escape from the burning fate
acceptableOfferListByNftId seals your doom
Only the strongest will survive
The atomic burnWithOffers consumes the room

@roiLeo roiLeo requested a review from a team as a code owner May 21, 2023 14:01
@roiLeo roiLeo requested review from vikiival and daiagi and removed request for a team May 21, 2023 14:01
@netlify
Copy link

netlify bot commented May 21, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c79fcea
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/646a24a5df66c8000837d763
😎 Deploy Preview https://deploy-preview-6058--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 21, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 21, 2023

AI-Generated Summary: This pull request modifies the burn functionality to only operate on active offers. It updates transactionBurn.ts and adds a new acceptableOfferListByNftId.graphql query. The changes include using batchAll instead of batch when offers are present, and updating the query name to 'acceptableOfferListByNftId'. This should result in more accurate burning of tokens with active offers.

@codeclimate
Copy link

codeclimate bot commented May 21, 2023

Code Climate has analyzed commit c79fcea and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@daiagi daiagi added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label May 21, 2023
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try

@vikiival vikiival merged commit d7fa626 into kodadot:main May 22, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented May 22, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

This was referenced May 25, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants