Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 NeoField & NeoInput #6160

Merged
merged 9 commits into from
Jun 9, 2023
Merged

🔧 NeoField & NeoInput #6160

merged 9 commits into from
Jun 9, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 5, 2023 •
edited

Related with #6116

  • fixed inputs padding
  • fixed text label weight & padding
  • fixed counter position
  • fixed error icon not showin
  • fixed textarea placeholder color
  • Removed duplicate import
  • Removed unused code

Screenshot 2023-06-05 at 14-39-14 KodaDot Low fees and low carbon minting KodaDot - NFT Market Explorer

// TODO

  • rewritte AddressInput
  • fix /transfer grouped fields
  • ??

@roiLeo roiLeo requested a review from a team as a code owner June 5, 2023 07:48
@roiLeo roiLeo requested review from vikiival and daiagi and removed request for a team June 5, 2023 07:48
@netlify
Copy link

netlify bot commented Jun 5, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f645739
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6481ccc93ce8b8000855dd4c
😎 Deploy Preview https://deploy-preview-6160--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 5, 2023

AI-Generated Summary: This pull request introduces changes in three files related to the NeoInput and NeoField components, with a total of 54 insertions and 62 deletions. A new file NeoField.scss has been created, which contains styles and imports for the NeoField component. Modifications have been made to both NeoField.vue and NeoInput.scss to update style imports. Several style changes have been applied to the NeoInput component, such as updating the input and textarea padding values.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Jun 5, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 5, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@prury
Copy link
Member

prury commented Jun 6, 2023

looking cool!
some small adjustments(RMRK1 and 2):
image
image

@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Jun 7, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 7, 2023

Now it look better, thank for the review

Screenshot 2023-06-07 at 09-39-06 KodaDot - NFT Market Explorer

@prury
Copy link
Member

prury commented Jun 7, 2023 •
edited

@roiLeo
Royalty rate on white mode:
image

Since you are dealing with fields and inputs, would it be impolite of me to ask you to fix the search bar on the profile page?
canary:
image
beta:
image

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 7, 2023

@roiLeo Royalty rate on white mode: image

Okay done.

Since you are dealing with fields and inputs, would it be impolite of me to ask you to fix the search bar on the profile page? canary: image beta: image

Hmmm.. this one is a bit more complet and need a total rewritte, I'll check it again when I have time

@prury
Copy link
Member

prury commented Jun 7, 2023

@roiLeo Royalty rate on white mode: image

Okay done.

Since you are dealing with fields and inputs, would it be impolite of me to ask you to fix the search bar on the profile page? canary: image beta: image

Hmmm.. this one is a bit more complet and need a total rewritte, I'll check it again when I have time

its best that i open a new issue then! ty, sorry to bother

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 7, 2023

its best that i open a new issue then! ty, sorry to bother

Plus I think we have a new profile page design in pipeline (but I can't find the related issue) @kodadot/design-squad

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 7, 2023
vikiival
vikiival approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ✅

@roiLeo roiLeo enabled auto-merge June 8, 2023 12:42
@reviewpad reviewpad bot removed the large Pull request is large label Jun 8, 2023
@reviewpad reviewpad bot added the medium Pull request is medium label Jun 8, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 8, 2023

Code Climate has analyzed commit f645739 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo mentioned this pull request Jun 8, 2023
Merged
@exezbcz
Copy link
Member

exezbcz commented Jun 8, 2023

@roiLeo correct

daiagi
daiagi approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@roiLeo roiLeo merged commit 3ba4cb5 into kodadot:main Jun 9, 2023
16 of 19 checks passed
This was referenced Jun 9, 2023
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@daiagi daiagi daiagi approved these changes

Assignees
No one assigned
Labels
medium Pull request is medium S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@roiLeo @prury @exezbcz @vikiival @daiagi