Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 profile page buttons #6187

Merged
merged 8 commits into from
Jun 9, 2023
Merged

🔧 profile page buttons #6187

merged 8 commits into from
Jun 9, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 8, 2023 •
edited

#6160 (comment)?

Screenshot 2023-06-08 at 14-38-32 NFT Artist Profile on KodaDot KodaDot - NFT Market Explorer
Screenshot 2023-06-08 at 14-40-21 NFT Artist Profile on KodaDot KodaDot - NFT Market Explorer
Screenshot 2023-06-09 at 08-44-09 NFT Artist Profile on KodaDot KodaDot - NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner June 8, 2023 12:41
@roiLeo roiLeo requested review from preschian and daiagi and removed request for a team June 8, 2023 12:41
@netlify
Copy link

netlify bot commented Jun 8, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3bb84ec
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64833b2133108b0008684617
😎 Deploy Preview https://deploy-preview-6187--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 8, 2023

AI-Generated Summary: This pull request modifies the profile buttons to make them neater and more visually consistent. It introduces changes to the ProfileDetail.vue, ModalWrapper.vue, and DonationButton.vue components. A "realworldFullPath" method has been added, reorganizing modal buttons using NeoButton and modifying the styling for a more unified appearance across buttons.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 8, 2023
@prury
Copy link
Member

prury commented Jun 8, 2023

Clicking on them only opens the link if you click on the image, not in the whole button per se.

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 8, 2023
@preschian preschian mentioned this pull request Jun 9, 2023
Closed
7 tasks
preschian
preschian requested changes Jun 9, 2023
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesnt work:

  • gift button to 404 page
  • qr code title

@reviewpad reviewpad bot added medium Pull request is medium and removed small Pull request is small labels Jun 9, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 9, 2023

doesnt work:

* gift button to 404 page

* qr code title

Thanks for the review, now fixed

Screenshot 2023-06-09 at 10-08-47 NFT Artist Profile on KodaDot KodaDot - NFT Market Explorer

@daiagi
Copy link
Contributor

daiagi commented Jun 9, 2023

image

can we add some gap or remove the double borders?

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 9, 2023

can we add some gap or remove the double borders?

Should be possible, but a bit long to debug. I think we might wait for the new design because they could disappear

@prury
Copy link
Member

prury commented Jun 9, 2023 •
edited

can we add some gap or remove the double borders?

Should be possible, but a bit long to debug. I think we might wait for the new design because they could disappear

totally agree, should be just a fast/easy fix just in case canary gets released before the profile page redesign

@prury prury closed this Jun 9, 2023
@prury
Copy link
Member

prury commented Jun 9, 2023

sorry, missclicked

@prury prury reopened this Jun 9, 2023
@daiagi
Copy link
Contributor

daiagi commented Jun 9, 2023

Should be possible, but a bit long to debug. I think we might wait for the new design because they could disappear

fine by me, let's see what the new design brings

@roiLeo @daiagi
Update components/rmrk/Profile/ProfileDetail.vue
eaf7177 
Co-authored-by: Luke Fishman <daiagi@gmail.com>
@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jun 9, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 9, 2023

Code Climate has analyzed commit eaf7177 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo merged commit 73ae02d into kodadot:main Jun 9, 2023
8 of 12 checks passed
@roiLeo roiLeo deleted the fix/profile/buttons branch June 9, 2023 14:46
This was referenced Jun 15, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@daiagi daiagi daiagi approved these changes

Assignees
No one assigned
Labels
medium Pull request is medium S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profile page - Icon alignment - Canary
4 participants
@roiLeo @prury @daiagi @preschian