Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 top collection buttons #6274

Merged
merged 3 commits into from
Jun 21, 2023
Merged

🔧 top collection buttons #6274

merged 3 commits into from
Jun 21, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 19, 2023 •
edited

Closes #6273

Screenshot 2023-06-19 at 08-35-33 KodaDot - NFT Market Explorer

edit:

  • removed unused code & better readability

@roiLeo roiLeo requested a review from a team as a code owner June 19, 2023 06:38
@roiLeo roiLeo requested review from daiagi and Jarsen136 and removed request for a team June 19, 2023 06:38
@netlify
Copy link

netlify bot commented Jun 19, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c413af3
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6492e2f3ef57590007d3c79f
😎 Deploy Preview https://deploy-preview-6274--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 19, 2023

AI-Generated Summary: This pull request modifies the _top-collections.scss file with a focus on simplifying the code. Specifically, it removes 5 lines and adds 1 new line to adjust the border-color styling within the .top-collection-controls.buttons .control class.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 19, 2023
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 19, 2023
@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 21, 2023

wait did it get fixed by #6298

@codeclimate
Copy link

codeclimate bot commented Jun 21, 2023

Code Climate has analyzed commit c413af3 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

Close or merge?

7q32la

@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 21, 2023

Close or merge?

merge since I removed unused code & add indentation

@vikiival vikiival merged commit 5c088c4 into kodadot:main Jun 21, 2023
19 checks passed
@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 21, 2023

but I'm still amazed by this bug (#6298) and if you have an idea why it happens when you import any libs/ui component (already tried to import NeoIcon instead of NeoButton and same bug occurs) let me know

This was referenced Jun 21, 2023
Merged
Merged
Merged
Merged
This was referenced Jun 28, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daiagi daiagi daiagi approved these changes

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NeoTabs border issue
4 participants
@roiLeo @vikiival @daiagi @prury