Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beta update #6357

Merged
merged 10 commits into from
Jun 29, 2023
Merged

beta update #6357

merged 10 commits into from
Jun 29, 2023

Conversation

yangwao
Copy link
Member

@yangwao yangwao commented Jun 29, 2023

🤖 Generated by Copilot at 0a13b9e

This pull request improves the UI and UX of the NFT gallery by adding features for displaying and importing drops, showing unlockable content of collections, and minting NFTs with a new slider component. It also updates and removes some dependencies, and deletes some unused components and files. It introduces the NeoSlider component from the @kodadot1/brick library, and uses it in the SimpleMint and RoyaltyForm components.

@yangwao yangwao added the beta label Jun 29, 2023
@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0a13b9e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/649d77de6575eb00079433b1
😎 Deploy Preview https://deploy-preview-6357--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for koda-beta ready!

Name Link
🔨 Latest commit 0a13b9e
🔍 Latest deploy log https://app.netlify.com/sites/koda-beta/deploys/649d77dea0517d000954e06d
😎 Deploy Preview https://deploy-preview-6357--koda-beta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yangwao yangwao marked this pull request as ready for review June 29, 2023 12:24
@yangwao yangwao requested a review from a team as a code owner June 29, 2023 12:24
@yangwao yangwao requested review from vikiival and daiagi and removed request for a team June 29, 2023 12:24
@yangwao yangwao merged commit 6c891de into beta Jun 29, 2023
10 of 11 checks passed
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 29, 2023

AI-Generated Summary: This pull request includes significant refactoring and alterations of multiple components in the application.

Notably, the BasicSlider.vue component has been entirely removed and is no longer used in other components such as RoyaltyForm.vue. Instead, a new component named NeoSlider has been introduced and used in files like SimpleMint.vue. In addition, multiple files related to rendering and handling the 'BoxPlot' chart type, including Container.vue, Canvas.vue, and containerOptions.ts, have been deleted.

The package dependencies have also been updated, reflecting the removal of @sgratzl/chartjs-chart-boxplot and v-emoji-picker from the dependencies. The version of @paraspell/sdk has been upgraded from ^1.1.9 to ^1.1.10 in both pnpm-lock.yaml and package.json.

A comprehensive review of the UI and functionalities previously provided by the deleted components/modules is recommended. Given the removal of the Appreciation.vue component, which handled emoji emoticon appreciation functionality, and NoCollection.vue, responsible for rendering a message when no collection exists, it's essential to ensure replacements are in place where needed.

Moreover, modest but notable changes in the source code of components like UnlockableCollectionInfo.vue, UnlockableContainer.vue, DropContainer.vue, DropCard.vue, AttributeTagInput.vue, and several others have been identified. These modifications involve changing conditional logic, changing property data, and altering component prop usage.

The code changes suggest a significant reorganization, re-structuring, and logic modification in parts of the code base associated with rendering UI components, handling interactive elements, and managing project dependencies. Please corroborate that these changes align with the project's intended functionality and path.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Jun 29, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 29, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants