Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update robots.txt #6286

Merged
merged 4 commits into from
Jun 21, 2023
Merged

feat: update robots.txt #6286

merged 4 commits into from
Jun 21, 2023

Conversation

floyd-li
Copy link
Member

@floyd-li floyd-li commented Jun 20, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at e0dff1c

Updated robots.txt to block unwanted crawlers and optimize site visibility.

🤖 Generated by Copilot at e0dff1c

robots.txt blocks
paths and subdomains to hide
autumn leaves falling

@floyd-li floyd-li requested a review from a team as a code owner June 20, 2023 02:24
@floyd-li floyd-li requested review from roiLeo and Jarsen136 and removed request for a team June 20, 2023 02:25
@kodabot
Copy link
Collaborator

kodabot commented Jun 20, 2023

SUCCESS @floyd-li PR for issue #6283 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2e870ee
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6492a202fdc5e50008796e80
😎 Deploy Preview https://deploy-preview-6286--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 20, 2023

AI-Generated Summary: This pull request updates the robots.txt file by adding 9 new disallowed path patterns, resulting in 1 file changed with 9 insertions and 1 deletion.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review docs labels Jun 20, 2023
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static/robots.txt Outdated Show resolved Hide resolved
@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jun 20, 2023
@yangwao
Copy link
Member

yangwao commented Jun 20, 2023

what happened with tests

image

@floyd-li
Copy link
Member Author

what happened with tests

image

hmm not sure what's happened. it should not be related with this pr 🤔️

@Jarsen136
Copy link
Contributor

image
I guess it should be related to this change
https://github.com/kodadot/nft-gallery/pull/6265/files

Could u pls take a look? @preschian

@yangwao yangwao requested a review from vikiival June 20, 2023 19:27
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing:

  • */collection/
  • sitemap

otherwise lgtm

@preschian
Copy link
Member

I guess it should be related to this change #6265 (files)

Could u pls take a look? @preschian

if still error I think we need to downgrade the version again in the meantime
Wandalen/wretry.action#93

@codeclimate
Copy link

codeclimate bot commented Jun 21, 2023

Code Climate has analyzed commit 2e870ee and detected 0 issues on this pull request.

View more on Code Climate.

@floyd-li
Copy link
Member Author

Missing:

* `*/collection/`

* sitemap

otherwise lgtm

updated

@Jarsen136
Copy link
Contributor

Missing:

  • */collection/

I'm not sure if we are going to disallow the collection details page. @yangwao

@yangwao
Copy link
Member

yangwao commented Jun 21, 2023

I'm not sure if we are going to disallow the collection details page. @yangwao

for now yes probably, later we will use allow option to list top10 which has liquidity tbh, time to play gods game as still learning what is best tactic as "e-shop" what to index and what to not.

The current goal is to have top10 great pages to show, rather 1000 sub-optimal ones.

We will be selecting pages to put online up

@yangwao
Copy link
Member

yangwao commented Jun 21, 2023

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Jun 21, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.66 USD/DOT ~ 6.438 $DOT
🧗 12zQP2JviSyZzAX2j31F2TR5uSvDNerruSJBWxEZXjW3KMaN
🔗 0x75ab994221c585009cbc1cff103beedde4ae02f49197259cb36362868b7582f1

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jun 21, 2023
@yangwao yangwao merged commit 37c5dcb into kodadot:main Jun 21, 2023
18 of 19 checks passed
This was referenced Jun 21, 2023
This was referenced Jun 28, 2023
@floyd-li floyd-li deleted the fix/6283 branch October 8, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow indexing few pages for crawling robots
7 participants