Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text and icon missing #6320

Merged
merged 1 commit into from
Jun 24, 2023
Merged

fix: text and icon missing #6320

merged 1 commit into from
Jun 24, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jun 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at 58e95e6

Added a new theme variable inverse-bg for contrast styling in scss/_theme.scss.

🤖 Generated by Copilot at 58e95e6

inverse-bg adds
contrast for components
a winter feature

@Jarsen136 Jarsen136 requested a review from a team as a code owner June 24, 2023 05:37
@Jarsen136 Jarsen136 requested review from preschian and vikiival and removed request for a team June 24, 2023 05:37
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 24, 2023

AI-Generated Summary: This pull request introduces a fix for the missing text and icon issue by updating the _theme.scss file. It adds two new variables, 'background-color-inverse' for both light and dark themes, improving the visibility of text and icons against their respective backgrounds.

@netlify
Copy link

netlify bot commented Jun 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 58e95e6
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64968117523ed60008857a12
😎 Deploy Preview https://deploy-preview-6320--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 24, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 24, 2023

Code Climate has analyzed commit 58e95e6 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit c9ddc37 into kodadot:main Jun 24, 2023
20 checks passed
This was referenced Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

layout icon missing
2 participants