Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: introduce no-follow links #6324

Merged
merged 1 commit into from
Jun 26, 2023
Merged

chore: introduce no-follow links #6324

merged 1 commit into from
Jun 26, 2023

Conversation

abhisheknaiidu
Copy link
Contributor

@abhisheknaiidu abhisheknaiidu commented Jun 24, 2023 •
edited

fixes #6285

My DOT address: 5DPRwfHKU7vKFWoW7HvK2xeVCTqGsK1j1hM2PWQVSB9fDh64

@abhisheknaiidu abhisheknaiidu requested a review from a team as a code owner June 24, 2023 10:22
@abhisheknaiidu abhisheknaiidu requested review from roiLeo and Jarsen136 and removed request for a team June 24, 2023 10:22
@kodabot
Copy link
Collaborator

kodabot commented Jun 24, 2023

WARNING @abhisheknaiidu PR for issue #6285 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6285

@netlify
Copy link

netlify bot commented Jun 24, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 205fd1b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6496c3f5316c750008f1546f
😎 Deploy Preview https://deploy-preview-6324--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 24, 2023

AI-Generated Summary: This pull request introduces no-follow links to various components in the application. It updates 20 files, making changes to 36 insertions and 26 deletions. The primary changes include adding the rel="nofollow" attribute to external links in Navbar.vue, TheFooter.vue, GalleryItemDescription.vue, and other components. This helps improve SEO and instruct search engines not to follow certain links, ensuring the proper flow of link equity throughout the site.

@reviewpad reviewpad bot added the small Pull request is small label Jun 24, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 24, 2023

Code Climate has analyzed commit 205fd1b and detected 0 issues on this pull request.

View more on Code Climate.

@abhisheknaiidu
Copy link
Contributor Author

@Jarsen136 whatever you mentioned in the last PR, i've fixed in this PR.

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jun 24, 2023
@vikiival
Copy link
Member

pay 15 usd

@vikiival vikiival merged commit 885d571 into kodadot:main Jun 26, 2023
18 of 19 checks passed
@vikiival
Copy link
Member

Thanks for the contribution ^-^ ❤️

@abhisheknaiidu
Copy link
Contributor Author

@vikiival one ques - how will I get the 15 USD

This was referenced Jun 28, 2023
Merged
Merged
Merged
Merged
@abhisheknaiidu abhisheknaiidu deleted the chore/no-follow-links branch July 1, 2023 09:43
This was referenced Jul 5, 2023
Merged
Merged
@abhisheknaiidu
Copy link
Contributor Author

my polkadot address - 5DPRwfHKU7vKFWoW7HvK2xeVCTqGsK1j1hM2PWQVSB9fDh64
@vikiival

@vikiival
Copy link
Member

pay 15 usd

@vikiival
Copy link
Member

Please follow a standard PR template, otherwise I am not able to pay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce no-follow on links
5 participants
@abhisheknaiidu @kodabot @vikiival @roiLeo @Jarsen136