Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 unlockable to free-drop #6337

Merged
merged 7 commits into from
Jun 27, 2023
Merged

🚚 unlockable to free-drop #6337

merged 7 commits into from
Jun 27, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Jun 26, 2023

  • 🚚 renamed to free-drop
  • 🐛 fixed drop url in navbar

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • Fixed naming as discussed with @yangwao

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at c1eb206

Renamed the unlockable page to free-drop and updated the navbar link accordingly. This reflects the new feature of offering free NFT drops to users.

🤖 Generated by Copilot at c1eb206

nuxt-link changes
free NFT drop awaits you
autumn leaves falling

@vikiival vikiival requested a review from a team as a code owner June 26, 2023 15:05
@vikiival vikiival requested review from daiagi and Jarsen136 and removed request for a team June 26, 2023 15:05
@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit dc07d96
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/649a82f19ab9b00008b5b524
😎 Deploy Preview https://deploy-preview-6337--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 26, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 26, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 26, 2023

AI-Generated Summary: This pull request consists of two patches:

  1. The first patch renames the unlockable.vue file to free-drop.vue under the pages/_prefix/drops directory, as indicated by the file relocation.
  2. The second patch updates the Navbar.vue component, fixing the drop URL in the navbar by changing the nuxt-link from /stmn/unlockable to /stmn/drops/free-drop.

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change the path /stmn/unlockable at other places.
image

@vikiival
Copy link
Member Author

Thanks for spot @Jarsen136 fixed in 0a0f333

@Jarsen136
Copy link
Contributor

Thanks for spot @Jarsen136 fixed in 0a0f333

You're welcome. There is still a left on component UnlockableLandingTag. Pls change it and also fix the eslint warning.

vikiival and others added 2 commits June 26, 2023 18:15
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jun 26, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 26, 2023

Code Climate has analyzed commit 86b0299 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy pizzy

@roiLeo roiLeo merged commit 7cea148 into main Jun 27, 2023
6 of 9 checks passed
@roiLeo roiLeo deleted the truck-unlockable-free-drop branch June 27, 2023 06:34
@vikiival vikiival mentioned this pull request Jun 27, 2023
7 tasks
This was referenced Jun 28, 2023
This was referenced Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants