Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 migrate b-upload to NeoUpload #6341

Merged
merged 7 commits into from
Jun 30, 2023
Merged

🔧 migrate b-upload to NeoUpload #6341

merged 7 commits into from
Jun 30, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 27, 2023 •
edited
Loading

part of #5852

  • migrate b-upload to NeoUpload
  • move DropUpload to /shared components folder

Minted with NeoUpload => /snek/gallery/3124270296-7

@roiLeo roiLeo requested a review from a team as a code owner June 27, 2023 12:52
@roiLeo roiLeo requested review from vikiival and daiagi and removed request for a team June 27, 2023 12:52
@netlify
Copy link

netlify bot commented Jun 27, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 18430a5
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/649ece04d65ded00087ab5a7
😎 Deploy Preview https://deploy-preview-6341--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 27, 2023

AI-Generated Summary: This pull request migrates the b-upload component to the new oruga based NeoUpload component. It includes updating the component usage within the DropUpload.vue, adding the NeoUpload.vue component file, and updating the imports and exports in the index.ts file. The changes involve 28 insertions and 3 deletions, while also adding the new NeoUpload.vue component file.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 27, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 27, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo mentioned this pull request Jun 27, 2023
Closed
37 tasks
@roiLeo roiLeo changed the title 🔧 migrate b-upload to NeoSlider 🔧 migrate b-upload to NeoUpload Jun 27, 2023
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 28, 2023
@vikiival vikiival enabled auto-merge (squash) June 29, 2023 15:18
@vikiival vikiival disabled auto-merge June 29, 2023 15:18
@vikiival
Copy link
Member

Can i merge?

@roiLeo roiLeo enabled auto-merge June 30, 2023 12:43
@codeclimate
Copy link

codeclimate bot commented Jun 30, 2023

Code Climate has analyzed commit 18430a5 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival disabled auto-merge June 30, 2023 13:53
@vikiival vikiival merged commit c0194ff into kodadot:main Jun 30, 2023
15 checks passed
@roiLeo roiLeo deleted the chore/Buefy/b-upload branch June 30, 2023 14:01
@yangwao yangwao mentioned this pull request Jul 5, 2023
Merged
@yangwao yangwao mentioned this pull request Jul 5, 2023
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roiLeo @vikiival @prury