Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Smol fixes on drop page #6356

Merged
merged 1 commit into from
Jun 29, 2023
Merged

fix: Smol fixes on drop page #6356

merged 1 commit into from
Jun 29, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Jun 29, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

Copilot Summary

🤖 Generated by Copilot at 658e37c

Refactored the DropCard and UnlockableCollectionInfo components to simplify their logic and props. Moved the UnlockableCollectionInfo component to a more appropriate folder.

🤖 Generated by Copilot at 658e37c

Oh, we're the coders of the sea, and we work with props and APIs
We fetch the data that we need, and we pass it down with ease
We move the components where they belong, and we simplify the logic when it's wrong
So heave away, me hearties, heave away, on the count of three, UnlockableCollectionInfo!

@kodabot
Copy link
Collaborator

kodabot commented Jun 29, 2023

SUCCESS @Jarsen136 PR for issue #6355 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 658e37c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/649d66cb6b8234000804bb77
😎 Deploy Preview https://deploy-preview-6356--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jarsen136 Jarsen136 marked this pull request as ready for review June 29, 2023 11:11
@Jarsen136 Jarsen136 requested a review from a team as a code owner June 29, 2023 11:11
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team June 29, 2023 11:11
@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 29, 2023

AI-Generated Summary: This pull request makes several changes across multiple components within the application to enhance their functionality. The majority of the changes involve updating the components to now receive a collectionId prop. Specifically, these changes were made in DropContainer.vue and UnlockableContainer.vue files.

Within the UnlockableCollectionInfo.vue file, the collectionId is now accepted as a property as well, replacing the collectionId imported from ./const. There's also the addition of a utility function for the description of unlockable items.

Moreover, in DropCard.vue, the redundancy of price presentation is eliminated. The conditional rendering of price Free or 1 DOT has been simplified to just return the price directly, simplifying the code and improving readability.

@reviewpad reviewpad bot added the small Pull request is small label Jun 29, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 29, 2023

Code Climate has analyzed commit 658e37c and detected 0 issues on this pull request.

View more on Code Climate.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 29, 2023
@yangwao
Copy link
Member

yangwao commented Jun 29, 2023

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Jun 29, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.99 USD/DOT ~ 6.012 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xfa98777972ac873e2ca0fd1079abbb070a8934b4cfdfd8c5c40aa05b1ee0d124

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jun 29, 2023
@yangwao yangwao merged commit 35ddd25 into kodadot:main Jun 29, 2023
19 of 20 checks passed
This was referenced Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smol fixes on drop page
5 participants