Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 stmn collection activity #6381

Merged
merged 1 commit into from
Jul 4, 2023
Merged

🔧 stmn collection activity #6381

merged 1 commit into from
Jul 4, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Jul 4, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

image

Copilot Summary

🤖 Generated by Copilot at 22e968c

Updated mintInteraction function to handle Statemine network prefix. This allows the composables to correctly identify the minting process for different networks.

🤖 Generated by Copilot at 22e968c

mintInteraction
Kusama networks share one way
Fall leaves of stmn

@daiagi daiagi requested a review from a team as a code owner July 4, 2023 05:50
@daiagi daiagi requested review from roiLeo and vikiival and removed request for a team July 4, 2023 05:50
@kodabot
Copy link
Collaborator

kodabot commented Jul 4, 2023

WARNING @daiagi PR for issue #6326 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6326

@netlify
Copy link

netlify bot commented Jul 4, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 22e968c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64a3b31f73a4040008fab7d6
😎 Deploy Preview https://deploy-preview-6381--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 4, 2023

AI-Generated Summary: This pull request includes changes to the composables/collectionActivity/helpers.ts file, particularly to the mintInteraction function. The new code adds an extra condition to check. It now returns Interaction.MINT if urlPrefix.value equals 'ksm' or 'stmn', and Interaction.MINTNFT for other cases. The purpose of this alteration is to properly handle 'stmn' in addition to the previously handled 'ksm'. This ensures appropriate interactions are triggered based on the URL prefix.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 4, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 4, 2023

Code Climate has analyzed commit 22e968c and detected 0 issues on this pull request.

View more on Code Climate.

@daiagi daiagi requested review from preschian and Jarsen136 and removed request for roiLeo and vikiival July 4, 2023 05:51
@vikiival vikiival merged commit 185a2ae into main Jul 4, 2023
16 checks passed
@vikiival vikiival deleted the fix/stmn-holders branch July 4, 2023 07:59
This was referenced Jul 5, 2023
This was referenced Jul 17, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statemine Holders won't show
4 participants