🔧 migrate b-navbar

[roiLeo]

• part of Goodbye Buefy #5852
• closes Navbar modal won't close when clicking explore items or collections #6395

@prury you have to check if nothing breaks in navbar (mobile, desktop, links etc..) compared to beta/canary

edit: Mobile navbar doesn't work hehe fixed 🎉

note: Didn't changed StatsDropdown component since it's not used

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	72bd5db
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/64a6c1c07516450008f9ba43
😎 Deploy Preview	https://deploy-preview-6382--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[reviewpad]

AI-Generated Summary: This pull request modifies the Navbar component in a Vue.js application. It migrates the structure of the Navigation bar from using <b-navbar> component to a more semantic HTML structure using <nav> and other related tags. Additionally, it changes the <b-navbar-item> tags in the 'CreateDropdown.vue' and 'MobileLanguageOption.vue' components to <nuxt-link> and <a> tags, respectively. The motivations for these changes are not mentioned, but likely due to improving code readability and accessibility, as '

' is an HTML5 semantic tag.

[daiagi]

looks good
didn't find anything that isn't working

[prury]

Mobile:

Javascript chain 😄 (only happened the first time i've entered using the deploy link )

---

When you are disconnected on mobile and try to connect, the burger menu is not closing to allow the user to connect:

connect.mp4

---

Language button when the wallet is disconnected on mobile:
it returns a 404 page or it refreshes and don't change the language

when those get fixed I'll do another round of testing

[roiLeo]

Blocked:

TypeError: can't access property "abstract", parent.$options is undefined
related with #6277

edit: found a workaround

[prury]

@roiLeo switching language on mobile changes the language but the modal won't close as soon as i click it, it keeps open.

[roiLeo]

@roiLeo switching language on mobile changes the language but the modal won't close as soon as i click it, it keeps open.

Isn't it the current behavior on beta? are you logged in?

[prury]

@roiLeo switching language on mobile changes the language but the modal won't close as soon as i click it, it keeps open.

Isn't it the current behavior on beta? are you logged in?

i'm not logged and using mobile

beta behavior:

beta.mp4

deploy:

6382.mp4

[roiLeo]

Should be good now, thanks for reporting

[prury]

Should be good now, thanks for reporting

ty, will do another round of testing now

[prury]

• scroll / search bar button issue(only happens on main page):

scroll.mp4

• Search button opening the entire modal (beta only shows the search bar itself):

search.button.opening.the.whole.modal.mp4

found a old bug: #6395

for now i think that's it, but i wouldn't mind testing a bit more later

[roiLeo]

• remove scroll when mobile navbar open

[roiLeo]

closes #6395, feel free to test again

[prury]

thanks a lot for the fixes @roiLeo

only problem i see now is this one:

search.mp4

search icon not appearing on other pages, only inside menu

[codeclimate]

Code Climate has analyzed commit 72bd5db and detected 0 issues on this pull request.

View more on Code Climate.

[roiLeo]

🚀 letsgo