Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6636 cards update #6700

Merged
merged 4 commits into from
Aug 17, 2023
Merged

#6636 cards update #6700

merged 4 commits into from
Aug 17, 2023

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Aug 14, 2023 •
edited by vikiival

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
Screen Shot 2023-08-13 at 5 21 01 PM Screen Shot 2023-08-13 at 5 21 07 PM

Copilot Summary

@prachi00 prachi00 requested a review from a team as a code owner August 14, 2023 00:22
@prachi00 prachi00 requested review from preschian and vikiival and removed request for a team August 14, 2023 00:22
@kodabot
Copy link
Collaborator

kodabot commented Aug 14, 2023

WARNING @prachi00 PR for issue #6636 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6636

@netlify
Copy link

netlify bot commented Aug 14, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5931809
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64da7c2318852000081845c3
😎 Deploy Preview https://deploy-preview-6700--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 14, 2023

AI-Generated Summary: This pull request includes a series of style changes for the items in the ItemsGrid component. The code changes involve modifying and adding some CSS styling to the component items, specifically, the in-cart-border styling. Instead of an outline, a border style has been applied and a background color has been added. Additionally, new color definitions for 'blue-light-cards' have been added to various theme files.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 14, 2023
@vikiival vikiival requested a review from exezbcz August 14, 2023 09:19
@exezbcz
Copy link
Member

exezbcz commented Aug 14, 2023

good, the gap is gone but now the stroke is inside and is making the content smaller everytime you add it to cart

  • it should be outside stroke - something like outline worked, but there was a gap

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Aug 14, 2023
@prachi00 prachi00 requested a review from daiagi August 14, 2023 19:10
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 14, 2023

Code Climate has analyzed commit 5931809 and detected 0 issues on this pull request.

View more on Code Climate.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 14, 2023
@prachi00
Copy link
Member Author

Screen Shot 2023-08-16 at 10 10 25 PM trying to push code, I get this @vikiival @yangwao

@vikiival
Copy link
Member

trying to push code, I get this

Please fork the repo under your personal profile and do a PR against upstream as usual

@yangwao
Copy link
Member

yangwao commented Aug 17, 2023

trying to push code, I get this @vikiival @yangwao

Yes, we've been checking our security permissions; you should do contributions through pull requests onwards.

@vikiival
Copy link
Member

pay 18 usd

@vikiival vikiival merged commit b626cec into main Aug 17, 2023
14 checks passed
@vikiival vikiival deleted the feat-cards-update branch August 17, 2023 10:20
@yangwao
Copy link
Member

yangwao commented Aug 17, 2023

😍 Perfect, I’ve sent the payout
💵 $18 @ 4.77 USD/DOT ~ 3.774 $DOT
🧗 13Qx65nLd6SwdtjrRyuoEtp9CKXhF651xdHBPaXcvhwKm4N1
🔗 0x73254d419db0ee0eea274e8f85de91c3e267767a0b0828f47ad28267d35531fd

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daiagi daiagi daiagi requested changes

@vikiival vikiival vikiival approved these changes

@exezbcz exezbcz exezbcz approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-changes-requested-🤞 PR is almost good to go, just some fine tunning S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NFT cards imperfections + background
7 participants
@prachi00 @kodabot @exezbcz @vikiival @yangwao @daiagi @prury