Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFT cards imperfections + background #6636

Closed
exezbcz opened this issue Aug 9, 2023 · 3 comments · Fixed by #6700
Closed

NFT cards imperfections + background #6636

exezbcz opened this issue Aug 9, 2023 · 3 comments · Fixed by #6700
Labels
$ ~<50usd A-cart for faster shoplifiting in kodadot A-item p2 core functionality, or is affecting 60% of app visual change not affecting ux of app

Comments

@exezbcz
Copy link
Member

exezbcz commented Aug 9, 2023

image

  • currently, there is a tiny gap between the stroke and the image - it's basically the old stroke that is replaced with an outline when the item is in the cart.
  • Can we please remake the card so there is no gap when selected

Bg change

  • to further distinguish selected items from non-selected, we change the background.
  • cards will look like this now
    image
  • page in handoff updated
@exezbcz exezbcz added $ ~<50usd p3 non-core, affecting less than 40% A-item visual change not affecting ux of app A-cart for faster shoplifiting in kodadot labels Aug 9, 2023
@prachi00 prachi00 self-assigned this Aug 10, 2023
@kodabot
Copy link
Collaborator

kodabot commented Aug 10, 2023

ASSIGNED - @prachi00 🔒 LOCKED -> Saturday, August 12th 2023, 09:25:43 UTC -> 36 hours

@kodabot
Copy link
Collaborator

kodabot commented Aug 12, 2023

ASSIGNMENT EXPIRED - @prachi00 has been unassigned.

@yangwao yangwao added p2 core functionality, or is affecting 60% of app and removed p3 non-core, affecting less than 40% labels Aug 13, 2023
@yangwao
Copy link
Member

yangwao commented Aug 13, 2023

@prachi00 are you working on this?

prachi00 added a commit that referenced this issue Aug 14, 2023
@prachi00
#6636 cards update
94a68f0
@prachi00 prachi00 mentioned this issue Aug 14, 2023
Merged
7 tasks
vikiival pushed a commit that referenced this issue Aug 17, 2023
@prachi00
#6636 cards update (#6700)
b626cec 
* #6636 cards update

* outline fix
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$ ~<50usd A-cart for faster shoplifiting in kodadot A-item p2 core functionality, or is affecting 60% of app visual change not affecting ux of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#6636 cards update kodadot/nft-gallery
4 participants
@yangwao @prachi00 @exezbcz @kodabot