Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove console error #6712

Merged
merged 1 commit into from
Aug 15, 2023
Merged

fix: remove console error #6712

merged 1 commit into from
Aug 15, 2023

Conversation

floyd-li
Copy link
Member

@floyd-li floyd-li commented Aug 15, 2023 •
edited by ghost

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

follow the type definition of oruga ui, that's the reason of the console's error.
image

now enjoy the clear console :)

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 3cde46d

Changed the autoClose prop type of the NeoTooltip component to accept an array of event names. This allows customizing the tooltip behavior based on different user interactions.

🤖 Generated by Copilot at 3cde46d

autoClose prop
array of events or bool
autumn leaves falling

@floyd-li floyd-li requested a review from a team as a code owner August 15, 2023 07:59
@floyd-li floyd-li requested review from preschian and Jarsen136 and removed request for a team August 15, 2023 07:59
@kodabot
Copy link
Collaborator

kodabot commented Aug 15, 2023

SUCCESS @floyd-li PR for issue #6706 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 15, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3cde46d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64db3046baa7bd00087ea647
😎 Deploy Preview https://deploy-preview-6712--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 15, 2023

AI-Generated Summary: This pull request contains a minor fix for the NeoTooltip component in the UI library. It modifies the type of the autoClose prop from any, or boolean, to either an array of strings or a boolean. This change helps to define the accepted type more specifically, potentially eliminating console errors that may have been occurring due to incorrect types being passed as props.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 15, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 15, 2023

Code Climate has analyzed commit 3cde46d and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@floyd-li
Copy link
Member Author

cc @daiagi

@floyd-li
Copy link
Member Author

seems there's something wrong on the preview site, maybe network issue🤔️
image

@preschian
Copy link
Member

seems there's something wrong on the preview site, maybe network issue🤔️

Yes, seems like Subsquid had a major outage

kodadot/uptime#1188

@yangwao
Copy link
Member

yangwao commented Aug 15, 2023

pay 20 usd
good hit @floyd-li

@yangwao yangwao merged commit c3ff15d into kodadot:main Aug 15, 2023
15 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 15, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.98 USD/DOT ~ 4.016 $DOT
🧗 13rv1SWoLg9Gb3tmvHPZxb7JbVy51BtMziX7k9WQGSJ7Kp3A
🔗 0xf166bb445bff59b0ed375eb691acd523552044a20b87bcf722e15a11cf71f2e7

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 15, 2023
@floyd-li floyd-li deleted the fix/6706 branch August 15, 2023 10:37
floyd-li added a commit to floyd-li/nft-gallery that referenced this pull request Aug 15, 2023
@floyd-li
Squashed commit of the following:
0d6dc5f 
commit 614a3b0
Author: Viki Val <viktorko99@gmail.com>
Date:   Tue Aug 15 13:02:11 2023 +0300

    :nail_care: Error into composition API (kodadot#6715)

commit c3ff15d
Merge: d3e2124 3cde46d
Author: Matej yangwao <5887929+yangwao@users.noreply.github.com>
Date:   Tue Aug 15 11:32:36 2023 +0200

    Merge pull request kodadot#6712 from floyd-li/fix/6706

commit d3e2124
Merge: df0e9f6 083969e
Author: Matej yangwao <5887929+yangwao@users.noreply.github.com>
Date:   Tue Aug 15 11:28:27 2023 +0200

    Merge pull request kodadot#6695 from Jarsen136/issue-6466

commit df0e9f6
Author: Jarsen <31397967+Jarsen136@users.noreply.github.com>
Date:   Tue Aug 15 16:50:35 2023 +0800

    fix: forbiding landing page on DOT (kodadot#6710)

commit 3cde46d
Author: Floyd Li <floyd.li@outlook.com>
Date:   Tue Aug 15 15:52:43 2023 +0800

    fix: remove console error

commit c96e3f9
Merge: 3fa9006 b8ddaca
Author: Matej yangwao <5887929+yangwao@users.noreply.github.com>
Date:   Tue Aug 15 09:24:43 2023 +0200

    Merge pull request kodadot#6699 from kodadot/renovate/bumped-minor-version-of-packages

    [skip netlify] Update Bumped minor version of packages

commit b8ddaca
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Aug 14 20:29:13 2023 +0000

    [skip netlify] Update Bumped minor version of packages

commit 083969e
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 23:42:30 2023 +0800

    fix: font size

commit ccf5a59
Merge: 03c51d1 d3102c9
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 22:53:47 2023 +0800

    Merge branch 'issue-6466' of github.com:Jarsen136/nft-gallery into issue-6466

commit 03c51d1
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 22:53:23 2023 +0800

    fix: transfer redesign

commit d3102c9
Merge: cc0d9d7 b123f32
Author: Viki Val <viktorko99@gmail.com>
Date:   Mon Aug 14 13:58:45 2023 +0300

    Merge branch 'main' into issue-6466

commit cc0d9d7
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 13:44:33 2023 +0800

    Revert "fix: flex to table"

    This reverts commit f3644a6.

commit f3644a6
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 10:51:25 2023 +0800

    fix: flex to table

commit 460345b
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 09:45:40 2023 +0800

    fix: UI issue

commit 9eb4954
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 00:25:46 2023 +0800

    fix: total value

commit 881a3b7
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 00:04:41 2023 +0800

    fix: redesign issue

commit 0be1770
Author: Jarsen <695552027@qq.com>
Date:   Sun Aug 13 21:39:12 2023 +0800

    feat: transfer transaction

commit 5911cb6
Author: Jarsen <695552027@qq.com>
Date:   Sun Aug 13 20:58:30 2023 +0800

    feat: Transfer Redesign handover - (2) Transaction confirm
This was referenced Aug 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NeoTooltip console warnings
4 participants
@floyd-li @kodabot @preschian @yangwao