Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💅 Error into composition API #6715

Merged
merged 2 commits into from
Aug 15, 2023
Merged

💅 Error into composition API #6715

merged 2 commits into from
Aug 15, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Aug 15, 2023 •
edited by ghost

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Copilot Summary

🤖 Generated by Copilot at e2830eb

Refactored Error component to use <script setup> syntax for Vue 3. Simplified props and computed properties with withDefaults and top-level declarations.

🤖 Generated by Copilot at e2830eb

<script setup> shines
Less boilerplate, more clarity
A fresh Vue for fall

@vikiival vikiival requested a review from a team as a code owner August 15, 2023 09:39
@vikiival vikiival requested review from roiLeo and daiagi and removed request for a team August 15, 2023 09:39
@netlify
Copy link

netlify bot commented Aug 15, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 37f1c9e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64db4a30dfcd4b0008d74fd3
😎 Deploy Preview https://deploy-preview-6715--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 15, 2023

AI-Generated Summary: This pull request includes refactoring of the Error.vue component code from the traditional options API to the Vue 3 Composition API. This includes changing the way properties like errorCode, hasImg, errorTitle, and errorSubtitle are defined and given default values. The imgSrc method is also updated to be a computed property in this new API. These changes represent a modernization of the codebase to align with Vue 3's improved patterns.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 15, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 15, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@yangwao
Copy link
Member

yangwao commented Aug 15, 2023

lol why netlify doesn't builds, prob not related with this pr?

@preschian
Copy link
Member

preschian commented Aug 15, 2023 •
edited

lol why netlify doesn't builds, prob not related with this pr?

sync the branch first with the main branch

fonts or partners still not exist in this commit https://github.com/kodadot/nft-gallery/tree/e2830eb07e422d0b47a4d6cdc5a745eb482c0990/static

should be moved there, this is on main branch https://github.com/kodadot/nft-gallery/tree/main/static

@codeclimate
Copy link

codeclimate bot commented Aug 15, 2023

Code Climate has analyzed commit 37f1c9e and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vikiival
Copy link
Member Author

Look like it was built thanks!

@vikiival vikiival merged commit 614a3b0 into main Aug 15, 2023
14 checks passed
@vikiival vikiival deleted the error-composition branch August 15, 2023 10:02
floyd-li added a commit to floyd-li/nft-gallery that referenced this pull request Aug 15, 2023
@floyd-li
Squashed commit of the following:
0d6dc5f 
commit 614a3b0
Author: Viki Val <viktorko99@gmail.com>
Date:   Tue Aug 15 13:02:11 2023 +0300

    :nail_care: Error into composition API (kodadot#6715)

commit c3ff15d
Merge: d3e2124 3cde46d
Author: Matej yangwao <5887929+yangwao@users.noreply.github.com>
Date:   Tue Aug 15 11:32:36 2023 +0200

    Merge pull request kodadot#6712 from floyd-li/fix/6706

commit d3e2124
Merge: df0e9f6 083969e
Author: Matej yangwao <5887929+yangwao@users.noreply.github.com>
Date:   Tue Aug 15 11:28:27 2023 +0200

    Merge pull request kodadot#6695 from Jarsen136/issue-6466

commit df0e9f6
Author: Jarsen <31397967+Jarsen136@users.noreply.github.com>
Date:   Tue Aug 15 16:50:35 2023 +0800

    fix: forbiding landing page on DOT (kodadot#6710)

commit 3cde46d
Author: Floyd Li <floyd.li@outlook.com>
Date:   Tue Aug 15 15:52:43 2023 +0800

    fix: remove console error

commit c96e3f9
Merge: 3fa9006 b8ddaca
Author: Matej yangwao <5887929+yangwao@users.noreply.github.com>
Date:   Tue Aug 15 09:24:43 2023 +0200

    Merge pull request kodadot#6699 from kodadot/renovate/bumped-minor-version-of-packages

    [skip netlify] Update Bumped minor version of packages

commit b8ddaca
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Aug 14 20:29:13 2023 +0000

    [skip netlify] Update Bumped minor version of packages

commit 083969e
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 23:42:30 2023 +0800

    fix: font size

commit ccf5a59
Merge: 03c51d1 d3102c9
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 22:53:47 2023 +0800

    Merge branch 'issue-6466' of github.com:Jarsen136/nft-gallery into issue-6466

commit 03c51d1
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 22:53:23 2023 +0800

    fix: transfer redesign

commit d3102c9
Merge: cc0d9d7 b123f32
Author: Viki Val <viktorko99@gmail.com>
Date:   Mon Aug 14 13:58:45 2023 +0300

    Merge branch 'main' into issue-6466

commit cc0d9d7
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 13:44:33 2023 +0800

    Revert "fix: flex to table"

    This reverts commit f3644a6.

commit f3644a6
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 10:51:25 2023 +0800

    fix: flex to table

commit 460345b
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 09:45:40 2023 +0800

    fix: UI issue

commit 9eb4954
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 00:25:46 2023 +0800

    fix: total value

commit 881a3b7
Author: Jarsen <695552027@qq.com>
Date:   Mon Aug 14 00:04:41 2023 +0800

    fix: redesign issue

commit 0be1770
Author: Jarsen <695552027@qq.com>
Date:   Sun Aug 13 21:39:12 2023 +0800

    feat: transfer transaction

commit 5911cb6
Author: Jarsen <695552027@qq.com>
Date:   Sun Aug 13 20:58:30 2023 +0800

    feat: Transfer Redesign handover - (2) Transaction confirm
This was referenced Aug 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vikiival @yangwao @preschian @roiLeo