Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: neo button hover color #6755

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix: neo button hover color #6755

merged 1 commit into from
Aug 18, 2023

Conversation

floyd-li
Copy link
Member

@floyd-li floyd-li commented Aug 17, 2023 •
edited by ghost

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
图片 图片

Copilot Summary

🤖 Generated by Copilot at 3211467

Added theme-based color to button text in NeoButton.scss. This improves the appearance and accessibility of the NeoButton component.

🤖 Generated by Copilot at 3211467

color for button
theme function sets the hue
dark mode adapts it

@floyd-li floyd-li requested a review from a team as a code owner August 17, 2023 12:35
@floyd-li floyd-li requested review from preschian and roiLeo and removed request for a team August 17, 2023 12:35
@kodabot
Copy link
Collaborator

kodabot commented Aug 17, 2023

SUCCESS @floyd-li PR for issue #6749 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 17, 2023 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3211467
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64de14183df0930008840796
😎 Deploy Preview https://deploy-preview-6755--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 17, 2023

AI-Generated Summary: This pull request includes a small fix on the UI side, specifically, adjusting the hover color of the 'NeoButton' component. The amendment adds a new color property under the hover state of the 'NeoButton' component in the corresponding SCSS file, using the theme variable 'text-color'. This change aims to improve the visibility and user interaction with the 'NeoButton' component.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 17, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 17, 2023

Code Climate has analyzed commit 3211467 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

roiLeo
roiLeo approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be good to look if there is no side effects

@floyd-li
Copy link
Member Author

might be good to look if there is no side effects

yes just checked. i think there's no other effects since this rule only affect NeoButton

@vikiival
Copy link
Member

@kodadot/qa-guild plz

@roiLeo
Copy link
Contributor

roiLeo commented Aug 17, 2023

yes just checked. i think there's no other effects since this rule only affect NeoButton

In fact, this component is used in several places (not only tabs)

@prury
Copy link
Member

prury commented Aug 17, 2023

tested a whole lot of buttons and they seem fine

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 17, 2023
@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels Aug 17, 2023
@thnaylor thnaylor mentioned this pull request Aug 18, 2023
Merged
16 tasks
@vikiival vikiival merged commit 881fdd4 into kodadot:main Aug 18, 2023
15 checks passed
@vikiival
Copy link
Member

pay 15 usd

@yangwao
Copy link
Member

yangwao commented Aug 18, 2023

😍 Perfect, I’ve sent the payout
💵 $15 @ 4.49 USD/DOT ~ 3.341 $DOT
🧗 13rv1SWoLg9Gb3tmvHPZxb7JbVy51BtMziX7k9WQGSJ7Kp3A
🔗 0x839b69c4227c6739e071028027b120f7b79562ee898da906ac389bea8738f02a

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 18, 2023
This was referenced Aug 18, 2023
Merged
Merged
Merged
Merged
@floyd-li floyd-li deleted the fix/6749 branch October 8, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@roiLeo roiLeo roiLeo approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabs hover effect dark mode
7 participants
@floyd-li @kodabot @vikiival @roiLeo @prury @yangwao @preschian