Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: teleport tabs hover color #6768

Merged
merged 3 commits into from
Aug 19, 2023
Merged

fix: teleport tabs hover color #6768

merged 3 commits into from
Aug 19, 2023

Conversation

thnaylor
Copy link
Contributor

@thnaylor thnaylor commented Aug 17, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image
image

Copilot Summary

🤖 Generated by Copilot at 4cc1ef7

Improved the appearance and theme compatibility of the teleport tabs component by using a variable for the hover color.

🤖 Generated by Copilot at 4cc1ef7

teleport tabs change
hover color from theme, not
black textColor kireji

@thnaylor thnaylor requested a review from a team as a code owner August 17, 2023 19:55
@thnaylor thnaylor requested review from preschian and Jarsen136 and removed request for a team August 17, 2023 19:55
@kodabot
Copy link
Collaborator

kodabot commented Aug 17, 2023

SUCCESS @thnaylor PR for issue #6763 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d54537c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64dfa9988179200008ab57e6
😎 Deploy Preview https://deploy-preview-6768--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 17, 2023

AI-Generated Summary: This pull request contains a minor update in the visual aspect of the TeleportTabs component in a Vue.js application. Specifically, the color of the tabs during the 'hover' state has been modified to align with the theme's text color. This change is likely intended to make the UI look more consistent.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 17, 2023
@thnaylor
Copy link
Contributor Author

I saw in PR #6755 that Neo button implements the theme & text color now so I'm wondering if it would be better to remove the entire theme from from ".teleport-tabs-button" in this PR as it seems like duplicate code and let the styles fall onto the NeoButton?

@Jarsen136
Copy link
Contributor

I saw in PR #6755 that Neo button implements the theme & text color now so I'm wondering if it would be better to remove the entire theme from from ".teleport-tabs-button" in this PR as it seems like duplicate code and let the styles fall onto the NeoButton?

Yes. You could have a try if it does not break something.

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codeclimate
Copy link

codeclimate bot commented Aug 18, 2023

Code Climate has analyzed commit d54537c and detected 0 issues on this pull request.

View more on Code Climate.

@thnaylor
Copy link
Contributor Author

Screenshot 📸

image

image

LGTM! It will be more consistent now.

@Jarsen136 Jarsen136 requested a review from exezbcz August 18, 2023 18:25
@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 18, 2023
@yangwao
Copy link
Member

yangwao commented Aug 19, 2023

pay 20 usd

@yangwao yangwao merged commit 4a9576b into kodadot:main Aug 19, 2023
14 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 19, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.49 USD/DOT ~ 4.454 $DOT
🧗 123PCJXhjb15i6JwVVRGd7KvN2sSNZrtPjr5doJq9oWctoTt
🔗 0x243deb79d16e0c88961b558a9609d58e4fd114faeab50a42c828b8f9f1d93111

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 19, 2023
This was referenced Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teleport buttons hover effect dark mode
6 participants