Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy link to tx in transaction dialog #7073

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Aug 31, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

image

Copilot Summary

🤖 Generated by Copilot at 8febe42

This pull request adds a feature to copy the transaction link from the TransactionLoader component and provides feedback to the user with a toast message. It also updates the English localization file with the new message.

🤖 Generated by Copilot at 8febe42

useToast to unleash the fire
Burn the bridges of the liars
copyTransactionLink to spread the word
The transaction of doom is heard

@Jarsen136 Jarsen136 requested a review from a team as a code owner August 31, 2023 13:58
@Jarsen136 Jarsen136 requested review from stephenjason89 and daiagi and removed request for a team August 31, 2023 13:58
@kodabot
Copy link
Collaborator

kodabot commented Aug 31, 2023

SUCCESS @Jarsen136 PR for issue #7068 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8febe42
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64f09c74b37c1b00082b7aa5
😎 Deploy Preview https://deploy-preview-7073--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 31, 2023

AI-Generated Summary: This pull request includes changes in two files, namely components/shared/TransactionLoader.vue and locales/en.json. The changes involve the enhancement of the TransactionLoader.vue component adding a feature to copy the transaction link. This is implemented via an additional button in the dialog which uses the clipboard API and changes to the UI to accommodate this new button. To the locales/en.json file, a new text element copyTransactionLink is added to the translation set with the default English language text being transaction link copied. This text is displayed as a toast notification after successfully copying the transaction link.

@reviewpad reviewpad bot added the small Pull request is small label Aug 31, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 31, 2023

Code Climate has analyzed commit 8febe42 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 31, 2023
@yangwao
Copy link
Member

yangwao commented Aug 31, 2023

thank you!
pay 30 usd

@yangwao yangwao merged commit b7c9cd0 into kodadot:main Aug 31, 2023
16 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 31, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.44 USD/DOT ~ 6.757 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x6ecbf434123999590cb764f84f1d4929ad0d6859cab2ddb255accbcfbfaceff6

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 31, 2023
This was referenced Sep 1, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we have copy link to tx in transaction dialog?
4 participants