-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Teleport DOT between Statemint and Polkadot #7278
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SUCCESS @Jarsen136 PR for issue #6540 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
AI-Generated Summary: This pull request implements the feature of teleporting DOT between Statemint and Polkadot. The main changes involve modifications in the Teleport.vue component and useChain.ts composable. The teleport options now include the Polkadot and Statemint chains. Also, the file locales/en.json has been updated to accept dynamic currency inputs instead of hardcoded 'KSM'. All these changes sum to an addition of 88 lines and removal of 23 lines in 4 files. |
i would rename Dot here because we are referring to the chain and not the token: Ahp to Polkadot: Polkadot to Ahp -> https://polkadot.subscan.io/tx/0x8705da52c61178aa20532c4053d443011c977821a5a86dca8ec9237976ba75c0 ✔️ @Jarsen136 lmk if you want to mess with ED, and I'll open an issue. (related: #7213) |
✅ FIXED
I would wait for #7263 to merge first because they are related, and then I will update its name.
It's the same issue as #7213, so it could be solved there instead of creating a new issue. |
okie, ty! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise code lgtm
Code Climate has analyzed commit dce6583 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
pay 30 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs QA check
Context
tx: https://assethub-polkadot.subscan.io/xcm_message/polkadot-4b577bee7cc388bc291b5210472061f89131a33b
tx: https://assethub-polkadot.subscan.io/xcm_message/polkadot-f34f6cc60aaff122fd6a79aa65753bc4b8e84d3c
Please note that the Existential Deposit on asset hub is 0.1 dot
Did your issue had any of the "$" label on it?
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at b16850c
This pull request adds support for multiple origin chains for the teleport feature, allowing users to transfer NFTs between Kusama, Polkadot, and Statemint. It refactors the
Teleport.vue
component and updates theuseChain.ts
andteleport.ts
utils to handle the different chains and currencies. It also modifies theteleport.receiveValue
translation string to dynamically display the currency symbol.🤖 Generated by Copilot at b16850c