Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable filtering by collections #7700

Merged
merged 3 commits into from
Oct 17, 2023
Merged

enable filtering by collections #7700

merged 3 commits into from
Oct 17, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Oct 17, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
    Uploading image.png…

Copilot Summary

🤖 Generated by Copilot at f54ac03

This pull request enables searching for NFTs by collection name on the Subsquid API. It modifies the tokenListWithSearch query and the useFetchSearch hook to accept and pass a collections parameter.

🤖 Generated by Copilot at f54ac03

To search for NFTs by collection
We added a new filter selection
We used useFetchSearch
And passed collections each
To the query with $collections injection

@daiagi daiagi requested a review from a team as a code owner October 17, 2023 08:38
@daiagi daiagi requested review from roiLeo and floyd-li and removed request for a team October 17, 2023 08:38
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit b7ef800
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/652e7056936423000827d36b
😎 Deploy Preview https://deploy-preview-7700--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 17, 2023

AI-Generated Summary: This pull request includes updates to the items grid and GraphQL query to support filtering by collections. The changes involve the addition of a 'collection' case within the 'useFetchSearch' function file useItemsGrid.ts, which assigns collection IDs to the 'collections' property. Moreover, the patch adds a new variable, '$collections', to the GraphQL query in the tokenListWithSearch.graphql file, which is then used as a filter condition in the 'tokenEntityList' and total count queries.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 17, 2023
@daiagi daiagi requested a review from Jarsen136 October 17, 2023 08:39
@daiagi
Copy link
Contributor Author

daiagi commented Oct 17, 2023

drafting coz it won't work until squid is deployed

@daiagi daiagi marked this pull request as draft October 17, 2023 08:49
@vikiival
Copy link
Member

@yangwao yangwao marked this pull request as ready for review October 17, 2023 11:29
@codeclimate
Copy link

codeclimate bot commented Oct 17, 2023

Code Climate has analyzed commit b7ef800 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yangwao
Copy link
Member

yangwao commented Oct 17, 2023

I guess it works yet I see some overflow on cards

image

@yangwao yangwao merged commit 613dd1b into main Oct 17, 2023
14 checks passed
@yangwao yangwao deleted the collection-filter branch October 17, 2023 13:23
@daiagi
Copy link
Contributor Author

daiagi commented Oct 17, 2023

@yangwao
overflow was fixed in #7697

This was referenced Oct 17, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection filter won't work on Ahp & Ahk
4 participants