-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Generative drop v0 #7745
The Generative drop v0 #7745
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SUCCESS @Jarsen136 PR for issue #7580 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
AI-Generated Summary: This pull request introduces two new Vue components: Generative.vue and GenerativePreview.vue in the collection/drop directory. The code also adds new functionality for generating NFTs, including mint arguments and metadata creation. A new drop type, "generative", has been included to handle different pricing models depending on the drop type. This update also provides UI enhancements such as time left for the 'mint' action and the ability for users to preview examples of possible drop variations. In terms of localization, English translations for "run" and "variations" have been added. Various GraphQL queries have been updated, and new computed properties have been added to support the new functionality. In particular, dropCollectionById now includes description metadata for the collection. The drop price is conditional based on the drop type. Overall, this PR adds the necessary features for users to mint generative NFTs on the platform. |
I got stuck at the final step of minting NFT. When I try to send the tx, it fails and tells me I have no permission to operate this collection. Would you mind helping me with this PR and pointing out what's wrong with it? @vikiival |
Please follow |
I did follow the guide. The meta of the generative drop is ![]() |
Meta should be null in this case i fixed the DB |
I have updated them accordingly. |
Because it failed https://assethub-kusama.subscan.io/extrinsic/0xf4f157a609689979848dcd87c68dade6a996e96953ebd3433296353f5b92fffd |
As this transaction was emitted from the server side, what should we do to deal with this failure? |
It should point to your address, honestly i do not know why it failed |
Only the collection's owner has permission to mint nft and send it to other address. I bet that's why the transaction failed. WDYT? @vikiival For the previous successful transaction, it was emitted by the collection's owner. emitted by: Gn84LKb5HSxc3SACayxCzKQcWESRMcT1VUCqeZURfGj6ASi However, for the failed one, it was emitted by the |
Yup I had really weird settings on this collection (according to blockchain - KodaBot was the owner, but vikiival had all the rights to mint. TL;DR I was able to mint but This timer is too low. I waited around a mintute to be redirected. So please show a correct time.
|
Interesting : ) Now It works for me as well.
Updated |
✅ All of them have been fixed. Thank you for pointing them out with the code. @vikiival |
Some questions: creation goes nicely: https://deploy-preview-7745--koda-canary.netlify.app/ahk/gallery/176-4 |
Yes, the user should click the button and choose their favourite image.
Updated. I have added the loading icon for it.
Done |
I would default it with ss58 of current chain () |
✅ Updated. I set a default value for it so the user does not have to click the |
one last thing, if i understood correctly, the image I'm seeing on the right side is what i get when i click mint, so, instead of example of drop we could change it to something else, maybe "Select your Variation" and change the Variation button to Generate. @exezbcz wdyt? |
It's intended because we set the same preview image for every image. |
@prury / @Jarsen136 Is there any blocker for this PR? |
Also can someone from @kodadot/internal-dev review? |
No. It's ready to review and merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
was just waiting about Exez opinion on this #7745 (comment), but will open a followup instead |
@prury I would remove the tag and create followup for more UI changes |
@Jarsen136 please remove: |
Co-authored-by: roiLeo <medina.leo42@gmail.com>
Co-authored-by: roiLeo <medina.leo42@gmail.com>
Code Climate has analyzed commit ce8c16d and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
I think there will be few refactor/iterations to improve codebase, now we can at least test it Thanks! |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
SonarCloud Quality Gate failed.
|
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs QA check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at 7e44249
This pull request adds support for generative NFTs with unlockable content of different MIME types. It introduces a new component
Generative.vue
and several subcomponents to render the generative drop UI. It also updates thedropCollectionById
query, theuseDrops
hook, and thepages/[prefix]/drops/[id].vue
file to handle the new drop type. It adds a new functiongenerativeTokenMintArgs
and modifies thecreateUnlockableMetadata
function to create the mint transaction arguments and metadata hash. It also adds some translation keys to thelocales/en.json
file.🤖 Generated by Copilot at 7e44249