Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Generative mints at mobile #7874

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix: Generative mints at mobile #7874

merged 2 commits into from
Oct 30, 2023

Conversation

Jarsen136
Copy link
Contributor

PR Type

  • Bugfix

Context

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner October 29, 2023 17:01
@Jarsen136 Jarsen136 requested review from preschian and floyd-li and removed request for a team October 29, 2023 17:01
@netlify
Copy link

netlify bot commented Oct 29, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 18d34f1
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/653f5f24c155a10008d966ce
😎 Deploy Preview https://deploy-preview-7874--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Oct 29, 2023

SUCCESS @Jarsen136 PR for issue #7869 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 29, 2023

AI-Generated Summary: This pull request includes changes made to the 'GenerativePreview.vue' file. Specifically, it adjusts the positioning of a '.fixed-right' element for mobile screen sizes. An @include mobile directive has been added, which changes the 'right' property to 1rem for mobile screens.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 29, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 29, 2023

Code Climate has analyzed commit 0099f90 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136 Jarsen136 added this pull request to the merge queue Oct 30, 2023
Merged via the queue into kodadot:main with commit 0f166cc Oct 30, 2023
8 of 12 checks passed
@Jarsen136 Jarsen136 deleted the issue-7869 branch October 30, 2023 07:45
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

This was referenced Nov 1, 2023
Merged
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@roiLeo roiLeo roiLeo approved these changes

@floyd-li floyd-li Awaiting requested review from floyd-li floyd-li is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generative mints at mobile
4 participants
@Jarsen136 @kodabot @preschian @roiLeo