fix: subscribe form missing on route navigation

[thnaylor]

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

• Bugfix
• Feature
• Refactoring

Context

• Closes Missing email signup input field in footer  #7724
• Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

• My DOT address: Payout

Comments

• Seems to be an issue when loading a script from useHead in a component when using nuxt internal navigation and the component gets remounted a second time.
• Substackapi script also expects a div with id 'custom-substack-embed' to exist so loading the script globally/premounted causes errors.

Copilot Summary

🤖 Generated by Copilot at dfd2ead

Improved substack script loading in CustomSubstackEmbed component. The component now creates and removes the script element on mount and unmount instead of using useHead.

🤖 Generated by Copilot at dfd2ead

CustomSubstackEmbed
Loads script on mount, unmount
Snowflakes melt away

[kodabot]

SUCCESS @thnaylor PR for issue #7724 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	b4e7f5e
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/654101dfd235e20008d7dab3
😎 Deploy Preview	https://deploy-preview-7886--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[reviewpad]

AI-Generated Summary: This pull request includes two patches from user tnaylor. The first patch fixes an issue where the subscribe form was missing on route navigation in the file CustomSubstackEmbed.vue. This was done by refactoring the script usage and creating the substackScript at runtime, along with appending it to the document head on component mounting and removing on unmount.

The second patch is a cleanup effort, removing an unused line of code where an id was being assigned to the substackScript within the onMounted method in the same file. These changes collectively enhance the robustness and cleanliness of the code.

[roiLeo]

already fixed in #7725

[thnaylor]

@roiLeo Oh nice! Testing out SSR!

I guess if the ETA for #7725 is indeterminate we could use this in the mean time or close it. 👍

[prury]

please update PR @thnaylor

[codeclimate]

Code Climate has analyzed commit b4e7f5e and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.1% Duplication

[yangwao]

thanks!
pay 20 usd

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.34 USD/DOT ~ 4.608 $DOT
🧗 123PCJXhjb15i6JwVVRGd7KvN2sSNZrtPjr5doJq9oWctoTt
🔗 0x1c0e3340a5aea188c98a878efc03544e1cdd2eb93800e530fcb7a39ffc510c67

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

[yangwao]

pay 20 usd

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.34 USD/DOT ~ 4.608 $DOT
🧗 123PCJXhjb15i6JwVVRGd7KvN2sSNZrtPjr5doJq9oWctoTt
🔗 0x7b04d937aed19b8f27d3b96fe552aa33fe70e80f583142b4cd8cdfe502ab38ba

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues