Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"to" below "from" on narrow device #8123

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Nov 17, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
    image

Copilot Summary

🤖[deprecated] Generated by Copilot at 34a7820

Improved the layout of the event row component for tablet devices. Used Bulma's classes and a custom variable to adjust the flex direction and spacing of the elements.

🤖[deprecated] Generated by Copilot at 34a7820

We're making the event row responsive
With flex-direction and until
We'll adjust the layout with a breakpoint
Heave away, me hearties, heave with skill

@daiagi daiagi requested a review from a team as a code owner November 17, 2023 08:20
@daiagi daiagi requested review from preschian and roiLeo and removed request for a team November 17, 2023 08:20
@kodabot
Copy link
Collaborator

kodabot commented Nov 17, 2023

SUCCESS @daiagi PR for issue #8117 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 34a7820
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6557225d07bed0000872f1a5
😎 Deploy Preview https://deploy-preview-8123--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codeclimate bot commented Nov 17, 2023

Code Climate has analyzed commit 34a7820 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or use column with responsive breakpoint?

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Nov 17, 2023
@yangwao
Copy link
Member

yangwao commented Nov 18, 2023

thanks!
pay 20 usd

@yangwao yangwao merged commit 24c6659 into main Nov 18, 2023
15 checks passed
@yangwao yangwao deleted the fix/collection-activity-mobile branch November 18, 2023 12:01
@reviewpad reviewpad bot added the small Pull request is small label Nov 18, 2023
@yangwao
Copy link
Member

yangwao commented Nov 18, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 5.14 USD/DOT ~ 3.891 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0xddb9c4a1f148b9436098f2a96679f2bef38db1c6555b996b61cfa41ce9f2ed96

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 18, 2023
This was referenced Nov 23, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection activity on mobile should not have horizontal scroll
6 participants