fix: videos in collection are not loading #8729
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
AI-Generated Summary: This pull request introduces a key fix to the issue of video images not loading in the VideoMedia view component. The update includes adding a reference to the video element and a new event listener for 'loadeddata', facilitating the playing and pausing of the video when not in autoplay mode and the source property is defined. The patch also introduces an import from '@vueuse/core' for the 'useEventListener'. As a result, this significantly improves the handling of video display and interactivity, making for a more user-friendly, dependable media interaction. |
hassnian
changed the title
roiLeo
added
the
S-code-lgtm-✅
|
@hassnian
https://deploy-preview-8729--koda-canary.netlify.app/ahk/gallery/315-9 |
prury
added
the
S-changes-requested-🤞
@prury it's working for me , wait a bit it will load eventually. that one takes some time
|
There was a problem hiding this comment.
Interesting. What is the root cause anyway?
Because if you see metadata for this item, https://kodadot.xyz/ahk/gallery/315-8 is using the Koda image placeholder as a poster
- metadata: image.w.kodadot.xyz/ipfs/bafkreidvztvbqfddfdoywlam755mg74ce6mgjavnbwzygbyq45dt6audjy
- image: https://image.w.kodadot.xyz/ipfs/bafkreidchqftqyioy6q776xmtwj62wk3qdgrqlsdsl7gv27qkecgzfbe2i
- animation_url: https://image.w.kodadot.xyz/ipfs/bafybeidknymqcfn5s4s2sa4sdzsacn6qkorkecf4ms4hczpv7bkldldiwu
|
|
||
| if (!autoPlay.value && props.src) { | ||
| useEventListener(video, 'loadeddata', () => { | ||
| video.value.play() |
There was a problem hiding this comment.
Because it will play video in milliseconds to show the thumbnail, the transferred size in the network will be higher than the canary, no?
There was a problem hiding this comment.
the transferred size in the network will be higher than the canary, no?
yes, just tested it to make sure
@preschian got any other solution ?
There was a problem hiding this comment.
Ideally, capture it on metadata workers: https://github.com/kodadot/workers/blob/main/image/src/routes/metadata.ts#L74-L76. And then store it on our indexer
There was a problem hiding this comment.
like first frame of video? That could be good I guess
after waiting 20m:
it does load when i go straight to the URL: |
hassnian
changed the title
|
@JustLuuuu does this work for u? |
wfm |
|
Code Climate has analyzed commit 6076fac and detected 0 issues on this pull request. View more on Code Climate. |
|
There was a problem hiding this comment.
I don't have a strong opinion on this one. I don't think this is an issue. Because the item uses a placeholder on the metadata, since this is on Assethub, I think it's better for the creator to update the metadata with a proper thumbnail/image instead.
But feel free to merge it
Because if you see metadata for this item, kodadot.xyz/ahk/gallery/315-8 is using the Koda image placeholder as a poster
|
indeed this pr is only about the preview issue |
|
pay 20 usd |
|
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
PR Type
Context
Did your issue had any of the "$" label on it?
Community participation
Screenshot 📸
no fix
CleanShot.2023-12-22.at.11.10.22.mp4
with fix
CleanShot.2023-12-22.at.11.08.28.mp4
Copilot Summary
copilot:summary
copilot:poem