Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stroke in profile collection filter and mobile tabs #9080

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jan 21, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

collection filter

CleanShot 2024-01-21 at 11 21 47

mobile tabs

CleanShot 2024-01-21 at 11 13 42@2x

Copy link

netlify bot commented Jan 21, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 6c5d12d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65ae1cec806ca600085b3f07
😎 Deploy Preview https://deploy-preview-9080--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jan 21, 2024

SUCCESS @hassnian PR for issue #9059 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link
Contributor

reviewpad bot commented Jan 21, 2024

AI-Generated Summary: This pull request includes a minor change in CollectionFilter.vue under the profile component. The change involves fixing the stroke in the profile collection filter by adjusting the CSS class properties for the NeoDropdownItem component. This is achieved by adding an emphasis on the border-0 property to ensure it takes precedence, improving the appearance of each collection item in the dropdown.

@reviewpad reviewpad bot added the small Pull request is small label Jan 21, 2024
@hassnian hassnian marked this pull request as ready for review January 21, 2024 05:27
@hassnian hassnian requested a review from a team as a code owner January 21, 2024 05:27
@hassnian hassnian requested review from roiLeo and Jarsen136 and removed request for a team January 21, 2024 05:27
@hassnian hassnian changed the title fix: stroke in profile collection filter fix: stroke in profile collection filter and tabs Jan 21, 2024
Copy link

codeclimate bot commented Jan 21, 2024

Code Climate has analyzed commit baec6b9 and detected 0 issues on this pull request.

View more on Code Climate.

@hassnian hassnian changed the title fix: stroke in profile collection filter and tabs fix: stroke in profile collection filter and mobile tabs Jan 21, 2024
@exezbcz
Copy link
Member

exezbcz commented Jan 21, 2024

works for me, lets continue to:

@roiLeo roiLeo added this pull request to the merge queue Jan 22, 2024
Merged via the queue into kodadot:main with commit 48dce8a Jan 22, 2024
11 of 14 checks passed
Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hassnian hassnian deleted the issue-9059 branch January 22, 2024 08:42
This was referenced Jan 24, 2024
@yangwao yangwao mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Profile tabs missing top border stroke in profile collection filter
5 participants