Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bigger collection filter in profile #9100

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jan 22, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

with #9080 stroke fix

CleanShot 2024-01-22 at 09 08 58@2x

no stroke fix

CleanShot 2024-01-22 at 09 20 09@2x

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9f3c37a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65adecc81dcdea0008e582fa
😎 Deploy Preview https://deploy-preview-9100--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jan 22, 2024

WARNING @hassnian PR for issue #9089 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #9089

Copy link
Contributor

reviewpad bot commented Jan 22, 2024

AI-Generated Summary: This pull request introduces an enhancement to the dropdown component in the profile collection filter. It includes a fix that increases the size of the dropdown and also makes it scrollable if the number of collections exceeds four. This improves user interaction by ensuring the drop menu is not overflowed. The patch modifies three files: CollectionFilter.vue, NeoDropdown.scss, and NeoDropdown.vue. Key changes include an additional check for a 'yScrollable' property, applying maximum height and overflow settings for scrollable dropdown in the SCSS file, and an update in the Vue file to support the new 'yScrollable' property.

@reviewpad reviewpad bot added the small Pull request is small label Jan 22, 2024
@hassnian hassnian marked this pull request as ready for review January 22, 2024 04:07
@hassnian hassnian requested review from a team as code owners January 22, 2024 04:07
@hassnian hassnian requested review from yangwao and Jarsen136 and removed request for a team January 22, 2024 04:07
@hassnian hassnian marked this pull request as draft January 22, 2024 04:14
@hassnian hassnian marked this pull request as ready for review January 22, 2024 04:19
Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codeclimate bot commented Jan 22, 2024

Code Climate has analyzed commit 9f3c37a and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Jan 22, 2024

thanks!
pay 20 usd

@yangwao yangwao merged commit e5a02fe into kodadot:main Jan 22, 2024
16 of 18 checks passed
@yangwao
Copy link
Member

yangwao commented Jan 22, 2024

😍 Perfect, I’ve sent the payout
💵 $20 @ 6.66 USD/DOT ~ 3.003 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x80e6ed37123cc30b0cf59f3c8f7d59484d636ce49bd19b1d7b07df6a32750794

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 22, 2024
@hassnian hassnian deleted the issue-9089 branch January 22, 2024 09:06
This was referenced Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bigger collection filter in profile
3 participants