Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💅 customize cookies #9403

Merged
merged 14 commits into from
May 3, 2024
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Feb 14, 2024

In Accordance with GDPR, user has now control over tracking cookies.

Screenshots

Screenshot 2024-02-14 at 19-37-45 KodaDot - NFT Market Explorer
Screenshot 2024-02-14 at 19-25-10 KodaDot - NFT Market Explorer
Screenshot 2024-02-14 at 19-26-30 KodaDot - NFT Market Explorer

Accept
Capture d’écran 2024-02-14 à 7 17 12 PM

Decline
Capture d’écran 2024-02-14 à 7 16 46 PM

What's missing

  •  small UI changes
  • clarity setting
  • double check text
  • locales/translation

@roiLeo roiLeo requested a review from a team as a code owner February 14, 2024 18:42
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team February 14, 2024 18:42
Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 7a76ca1
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6634871c8dc6ab00086c8f0c
😎 Deploy Preview https://deploy-preview-9403--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roiLeo roiLeo changed the title 💅 customize cookie banner 💅 customize cookies Feb 14, 2024
@prury
Copy link
Member

prury commented Feb 14, 2024

wheres my data-testid 😢 (i accept it on tests because it sometimes gets in the way of some elements I'm trying to click on page)

can't disable/enable cookie control, is it supposed to be like that?

edit:

mobile:
image

@yangwao
Copy link
Member

yangwao commented Feb 15, 2024

Hey @roiLeo thanks for PR

I don't see the text "Being on our site, you agree with our cookie policy", can you adjust please?

Is it default on?

@roiLeo
Copy link
Contributor Author

roiLeo commented Feb 15, 2024

wheres my data-testid 😢 (i accept it on tests because it sometimes gets in the way of some elements I'm trying to click on page)

✅ fixed using page selector instead of data-id

can't disable/enable cookie control, is it supposed to be like that?

this is excepted see title "Necessary cookies", some cookies are needed for proper operation like theme color, if the cookie banner has already been accepted

mobile
✅ fixed

I don't see the text "Being on our site, you agree with our cookie policy", can you adjust please?

Screenshot 2024-02-15 at 10-01-34 KodaDot - NFT Market Explorer

Is it default on?

yes, default ON, even on page load

Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@prury
Copy link
Member

prury commented Feb 15, 2024

wheres my data-testid 😢 (i accept it on tests because it sometimes gets in the way of some elements I'm trying to click on page)

✅ fixed using page selector instead of data-id

can't disable/enable cookie control, is it supposed to be like that?

this is excepted see title "Necessary cookies", some cookies are needed for proper operation like theme color, if the cookie banner has already been accepted

mobile
✅ fixed

thank you

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review labels Feb 15, 2024
@prury
Copy link
Member

prury commented Apr 4, 2024

👀

@vikiival vikiival requested a review from preschian April 26, 2024 11:12
preschian and others added 2 commits May 2, 2024 20:10
Copy link

codeclimate bot commented May 3, 2024

Code Climate has analyzed commit 7a76ca1 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yangwao
Copy link
Member

yangwao commented May 3, 2024

Thanks @roiLeo for finishing this one.

@yangwao yangwao merged commit f39994a into kodadot:main May 3, 2024
19 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants