Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Limit ability to go minus on mass mint drop #9775

Merged
merged 5 commits into from
Mar 14, 2024

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Mar 14, 2024

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

image

Copilot Summary

copilot:summary

copilot:poem

@Jarsen136 Jarsen136 requested a review from a team as a code owner March 14, 2024 14:49
@Jarsen136 Jarsen136 requested review from preschian and removed request for a team March 14, 2024 14:49
@kodabot
Copy link
Collaborator

kodabot commented Mar 14, 2024

WARNING @Jarsen136 PR for issue #9761 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #9761

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 37496bc
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65f33c580bcbb10008752d7d
😎 Deploy Preview https://deploy-preview-9775--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Mar 14, 2024
@Jarsen136
Copy link
Contributor Author

✅ Fixed another issue #9779 on current PR

cc @exezbcz

@exezbcz
Copy link
Member

exezbcz commented Mar 14, 2024

lets go, frontrunning

i have one request tho, you cannot input 3 by overriding it

Screen.Recording.2024-03-14.at.17.48.27.mov

@prury prury removed the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Mar 14, 2024
@prury prury requested review from vikiival and daiagi and removed request for preschian March 14, 2024 17:47
@prury
Copy link
Member

prury commented Mar 14, 2024

lets go, frontrunning

i have one request tho, you cannot input 3 by overriding it
Screen.Recording.2024-03-14.at.17.48.27.mov

oh, its true, chrome only tho

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Mar 14, 2024
Copy link

codeclimate bot commented Mar 14, 2024

Code Climate has analyzed commit 37496bc and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@Jarsen136
Copy link
Contributor Author

lets go, frontrunning

i have one request tho, you cannot input 3 by overriding it

✅ Fixed
enable overriding number on input

@yangwao
Copy link
Member

yangwao commented Mar 14, 2024

✅ Fixed
enable overriding number on input

@exezbcz have some points but he will articulate in video soon :D probably follow up

Thanks!
pay 30 usd

@yangwao yangwao merged commit cd930af into kodadot:main Mar 14, 2024
19 of 20 checks passed
@yangwao
Copy link
Member

yangwao commented Mar 14, 2024

😍 Perfect, I’ve sent the payout
💵 $30 @ 11.43 USD/DOT ~ 2.625 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xb43a174a6d525687256c6165a6ae81b05dcdd424bbd16fa87506cdb0a21fe016

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 14, 2024
This was referenced Mar 14, 2024
@yangwao yangwao mentioned this pull request Mar 21, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-changes-requested-🤞 PR is almost good to go, just some fine tunning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step button in mass mint drop page Limit ability to go minus on mass mint drop
5 participants