Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick fix scale and update default values bug (#3163) to 2.0.0 #3164

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

PetrusZ
Copy link
Contributor

@PetrusZ PetrusZ commented Oct 27, 2023

What this PR does / Why we need it:

🤖 Generated by Copilot at 2d4bf7d

This pull request refactors the aslan microservice to improve the code quality and modularity. It removes unused and redundant code, splits the service.go file into two files, and renames a function to better reflect its functionality.

What is changed and how it works?

🤖 Generated by Copilot at 2d4bf7d

  • Remove unused import of util package from handler package (link)
  • Rename ScaleNewService function to ScaleNewProductionService in router.go file (link)
  • Add ScaleNewProductionService function to service.go file to handle scaling of services in production environments (link)
  • Remove license check logic from UpdateHelmProductDefaultValues function in environment.go file as part of a larger refactor to move license check to hub microservice (link)

Does this PR introduce a user-facing change?

  • API change
  • database schema change
  • upgrade assistant change
  • change in non-functional attributes such as efficiency or availability
  • fix of a previous issue

Signed-off-by: Patrick Zhao <zhaoyu@koderover.com>
@PetrusZ PetrusZ changed the base branch from main to release-2.0.0 October 27, 2023 06:33
@AllenShen AllenShen merged commit 606d32c into koderover:release-2.0.0 Oct 27, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants