Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick #3171 to 2.0.0 #3181

Merged

Conversation

PetrusZ
Copy link
Contributor

@PetrusZ PetrusZ commented Nov 3, 2023

  • add error to list group func
  • add render check before upsertService

What this PR does / Why we need it:

🤖 Generated by Copilot at 70d69db

This pull request enhances the error handling and reporting of the service operations for updating Kubernetes resources of a product environment. It adds a new Error field to the ServiceResp type and assigns it the value of the Error field of the Service type, which is populated by the render check function. It also improves the logic of the environment update function in environment_update.go.

What is changed and how it works?

🤖 Generated by Copilot at 70d69db

  • Add Error field to ServiceResp type to store service operation error messages (link)
  • Update updateK8sProduct function to handle service errors and return them as part of the product response (link)
    • Remove redundant assignment of error message to productErrMsg variable (link)
  • Assign service error field to service response error field in k8s.go to return render check errors to caller (link)

Does this PR introduce a user-facing change?

  • API change
  • database schema change
  • upgrade assistant change
  • change in non-functional attributes such as efficiency or availability
  • fix of a previous issue

* add error to list group func

Signed-off-by: Patrick Zhao <zhaoyu@koderover.com>

* add render check before upsertService

Signed-off-by: Patrick Zhao <zhaoyu@koderover.com>

---------

Signed-off-by: Patrick Zhao <zhaoyu@koderover.com>
@AllenShen AllenShen merged commit 4a328f7 into koderover:release-2.0.0 Nov 3, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants