Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mysql execute error (#3197) #3222

Merged

Conversation

AllenShen
Copy link
Contributor

@AllenShen AllenShen commented Dec 1, 2023

  • add mysql exec log

  • add mysql exec log

  • add mysql exec log

  • remove useless code


What this PR does / Why we need it:

🤖[deprecated] Generated by Copilot at 936c87d

Fixed a bug and improved code quality in workflowcontroller service. Removed unused imports and corrected MySQL connection string in job_sql.go.

What is changed and how it works?

🤖[deprecated] Generated by Copilot at 936c87d

  • Remove unused imports of net/url and _ "github.com/go-sql-driver/mysql" from jobcontroller package (link)
  • Fix bug in database connection string by removing url.QueryEscape function from password (link)

Does this PR introduce a user-facing change?

  • API change
  • database schema change
  • upgrade assistant change
  • change in non-functional attributes such as efficiency or availability
  • fix of a previous issue

* add mysql exec log

Signed-off-by: allenshen <shendongdong@koderover.com>

* add mysql exec log

Signed-off-by: allenshen <shendongdong@koderover.com>

* add mysql exec log

Signed-off-by: allenshen <shendongdong@koderover.com>

* remove useless code

Signed-off-by: allenshen <shendongdong@koderover.com>

---------

Signed-off-by: allenshen <shendongdong@koderover.com>
@AllenShen AllenShen merged commit 7152eea into koderover:release-2.0.0 Dec 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant