Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix delete k8s env bug #3237

Merged
merged 2 commits into from
Dec 8, 2023
Merged

fix delete k8s env bug #3237

merged 2 commits into from
Dec 8, 2023

Conversation

PetrusZ
Copy link
Contributor

@PetrusZ PetrusZ commented Dec 8, 2023

What this PR does / Why we need it:

🤖[deprecated] Generated by Copilot at a1bee35

This pull request improves the logging of the DeleteProduct function in pkg/microservice/aslan/core/environment/service/environment.go. It adds debug log statements to track the progress and errors of deleting a product and its associated environments.

What is changed and how it works?

🤖[deprecated] Generated by Copilot at a1bee35

  • Add debug log statements to DeleteProduct function in environment.go to help troubleshoot deletion failures (link, link, link, link, link, link)
  • Log the product name and the number of environments before deleting them (link)
  • Log the environment name and the error before deleting each environment (link)
  • Log the condition and the error for deleting a default environment (link)
  • Log the error for deleting a non-default environment (link)
  • Log the error after deleting all environments (link)
  • Log the final result and the error of the function (link)

Does this PR introduce a user-facing change?

  • API change
  • database schema change
  • upgrade assistant change
  • change in non-functional attributes such as efficiency or availability
  • fix of a previous issue

Signed-off-by: Patrick Zhao <zhaoyu@koderover.com>
Signed-off-by: Patrick Zhao <zhaoyu@koderover.com>
@AllenShen AllenShen merged commit 7935ff2 into koderover:main Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants